Skip to content
Snippets Groups Projects

Clean up ICaloElectron

Merged Carla Marin Benito requested to merge cmb_caloelectron into master

We currently have two very similar interfaces, https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/CaloFuture/include/CaloFutureUtils/ICaloElectron.h and https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/CaloFuture/include/CaloFutureInterfaces/ICaloFutureElectron.h The first ones does not have an actual implementation or at least I cannot find it. Calo reconstruction algorithms use the latter.

This MR removes the ICaloElectron interface. The only place where it is still used are some Falvour Tagging algorithms, namely:

The corresponding cpp files set the tool to "CaloElectron" but such a tool does not exist as far as I can see. Is this actually being used or working at all @cprouve @bkhanji ? Could the Flavour Algorithms use ICaloFutureElectron instead?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading