Skip to content
Snippets Groups Projects

Protect the muon decoding from unexpected data

Merged Rosen Matev requested to merge rm-muon-decoding-protections into master
All threads resolved!

Currently the decoding throws exceptions when a raw bank doesn't look as expected. These are replaced with error counters, and processing of the rest of the raw banks continues.

In addition, some assumptions (that seem to be violated with the current data) are now checked, preventing SIGABRT (invalid subspan arguments).

Adresses #242 but there are most certainly more issues as infrequent SIGABRT happens still in the MuonMon task.

/cc @samarian @mstahl

Merge request reports

Merge request pipeline #4649340 passed

Merge request pipeline passed for b60fcf2a

Approval is optional

Merged by Rosen MatevRosen Matev 2 years ago (Oct 21, 2022 3:53pm UTC)

Merge details

  • Changes merged into master with e7120b65.
  • Deleted the source branch.

Pipeline #4655442 passed

Pipeline passed for e7120b65 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rosen Matev mentioned in issue #242

    mentioned in issue #242

    • Resolved by Rosen Matev

      @rmatev thanks for this! Would it be possible to open an analogous request for Allen, or is that not necessary because of how Allen implements its decoding? In general we should from now on fix decoding issues simultaneously for HLT1 and HLT2.

  • Rosen Matev added 3 commits

    added 3 commits

    Compare with previous version

  • mentioned in issue Moore#474 (closed)

  • Saverio Mariani mentioned in merge request Allen!984 (merged)

    mentioned in merge request Allen!984 (merged)

  • Rosen Matev
  • mentioned in issue Moore#478 (closed)

  • Rosen Matev added 225 commits

    added 225 commits

    • 00f667ac...f534b5d9 - 223 commits from branch master
    • b773fb7b - Protect the muon decoding from unexpected data
    • b60fcf2a - Move checks for Tell40 integrity in a separate loop

    Compare with previous version

  • Rosen Matev resolved all threads

    resolved all threads

  • Rosen Matev mentioned in issue #268

    mentioned in issue #268

  • merged

  • Rosen Matev mentioned in commit e7120b65

    mentioned in commit e7120b65

  • Please register or sign in to reply
    Loading