Protect against null condition pointer in DeRichPMT::readPMTPropertiesFromDB

ported from !3737 (merged)

FYI @gcorti @seaso @bmalecki

assigned to @jonrob

changed the description

assigned to @gcorti and unassigned @jonrob

added all-slots label

added RICH bug fix labels

Thank you @jonrob !

• [2022-08-24 00:06] Validation started with lhcb-gauss-dev#3256
• [2022-08-24 00:32] Validation started with lhcb-sim10#1281
• [2022-08-24 10:34] Validation started with lhcb-sim10#1282
• [2022-08-25 00:04] Validation started with lhcb-gauss-dev#3257
• [2022-08-25 00:19] Validation started with lhcb-sim10#1283

Hello,

@jonrob the specific RICH tests are now all successful in lhcb-sim10 with this MR but the DetDescChecks/loaddddb-sim-upgrade test still has a core dump.

It seems to be related to the RichSmartID... there are also a set of RICH PMT inconcistencies...
03 - Rich1/PMTPanel0 ERROR Inconsistent results from dePMT(RichSmartID)

added 3 commits

• ef3cdb8c - Tune 'zero' detection in Rich1DTabFunc printout
• e4568a0a - RICH: keep empty spaces in the numbering scheme for non-existent
• 92791de2 - DeRichPMT::readPMTPropertiesFromDB: Protect against null condition pointer

Compare with previous version

added 1 commit

• d9478082 - DeRichPMTPanel: protect against null test PD pointer

Compare with previous version

resolved all threads

mentioned in commit f41d7cb9

merged

removed all-slots label