Add Hcal and Ecal to default dd4hep detector lists

Add Ecal and Hcal to default dd4hep det list and to DD4Hep conditions accessor test.

Needs Detector!275 (merged)

assigned to @chenjia

added RTA label

mentioned in issue Rec#387 (closed)

added 1 commit

• e9f18b24 - DetectorTests.cpp

Compare with previous version

marked this merge request as draft

changed the description

added Calo dd4hep labels

added 1 commit

• e7fd78b1 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit

• 306aa9ab - change

Compare with previous version

mentioned in merge request Detector!274 (merged)

added 1 commit

• ea28bec3 - DetectorTests.cpp

Compare with previous version

added 1 commit

• 32bdd02e - DetectorTests.cpp

Compare with previous version

@chenjia Please can you address the pipeline formatting issues here. See instructions in https://gitlab.cern.ch/lhcb/LHCb/-/jobs/24170048

@chenjia In future please can you use more meaningful commit messages. messages like test or change are not really good enough.

I will squash the changes this time, so will apply a new message myself when it is merged, but in future it would be better if you supply useful messages yourself.

added 1 commit

• b509981c - Fixed formatting

Compare with previous version

mentioned in merge request Moore!1743 (merged)

@chenjia @cmarinbe What's the status here, there hasn't been much feedback here for a while now. Is this MR ready for testing ? If so please remove the Draft status.

added 146 commits

• b509981c...aac53cf2 - 139 commits from branch master
• 7dc36a07 - test
• 9b7334b8 - DetectorTests.cpp
• 79354584 - Apply 1 suggestion(s) to 1 file(s)
• 4d67f79c - change
• 311e00e9 - DetectorTests.cpp
• f3340989 - DetectorTests.cpp
• 2633e897 - Fixed formatting

Compare with previous version

@chenjia CYI rebase against master.

marked this merge request as ready

mentioned in merge request Detector!275 (merged)

assigned to @jonrob

• [2022-09-22 15:35] Validation started with lhcb-master-mr#5719
• [2022-09-22 16:37] Validation started with lhcb-master-mr#5721
• [2022-09-22 17:57] Validation started with lhcb-master-mr#5724

added 1 commit

• 00147dc8 - LbDD4hep DetectorTests - ensure location function always has a return statement

Compare with previous version

added 1 commit

• ad3714c2 - Synchronise dd4hep detector lists

Compare with previous version

added 1 commit

• 278c287b - Synchronise dd4hep detector lists

Compare with previous version

• [2022-09-22 18:14] Validation started with lhcb-master-mr#5725
• [2022-09-22 21:02] Validation started with lhcb-master-mr#5726
• [2022-09-22 22:05] Validation started with lhcb-master-mr#5727
• [2022-09-23 00:03] Validation started with lhcb-dd4hep-rootunits#50
• [2022-09-23 00:04] Validation started with lhcb-dd4hep#1277
• [2022-09-23 11:32] Validation started with lhcb-master-mr#5736

changed the description

changed title from Add Hcal Ecal to default dd4hep det list to Add Hcal and Ecal to default dd4hep detector lists

added 1 commit

• d74b0f7b - DetectorTests - Fix initialize()

Compare with previous version

added lhcb-dd4hep label

added 1 commit

• f3af1658 - DetectorTests - Prefer std::string::find to strcasecmp

Compare with previous version

resolved all threads

merged

mentioned in commit d43e6292

unassigned @jonrob