MuonChamberLayout create tile id vector only locally to make move operator safe

This tries to solve a spurious crash observed when fitting SeedMuon tracks. So far I was not able to reliably reproduce the crash, but I suspect that the memory holding some tile ids is freed twice. To avoid this the corresponding data member is removed and only local/temporary vectors are used to make the move operation safe. Also removes unnecessary unsigned and int mixtures to avoid casts.

The crash report can be found here.

FYI @rmatev @sponce

added Muon bug fix labels

assigned to @gunther

/ci-test --platforms=x86_64_v2-centos7-gcc11-dbg

added RTA label

added ci-test-triggered label

• [2022-08-26 16:15] Validation started with lhcb-master-mr#5516
• [2022-08-27 14:50] Validation started with lhcb-master-mr#5522

marked this merge request as ready

changed the description

resolved all threads

@rmatev with these changes I haven't hit the problem anymore

/ci-test

changed the description

resolved all threads

approved this merge request

assigned to @rmatev

changed the description

unassigned @gunther

FYI @satta @desimone

approved this merge request

merged