Make all writers and decoders to use RawBank::View

Closes #179 (closed): make sure that a RawEvent which 'supports' RawBank::Views in the TES cannot be modified (which would invalidate the views) by writing it using writeViewFor with a view that does not allow access. Some syntactic sugar i.e. template <typename T> using writeOnly = writeViewFor<T,OpaqueView>; has been added to LHCbAlgs/Traits.h (which is included by the functional algorithms types defined in LHCbAlgs) for convenience.

To go with Moore!1900 (merged) Allen!1070 (merged) MooreAnalysis!98 (merged)

Supersedes !3390 (closed)

added 1 commit

• 821fc131 - fix the location names for packed buffer writer

Compare with previous version

added 1 commit

• 1081468d - Make HltLumiWriter not to modify the event

Compare with previous version

marked this merge request as draft

@graven I think with this all writers and decoders should be compatible with using RawBank::View in the new opaque way. I am not sure if I missed any.

marked this merge request as ready

changed title from Draft: make routing bits and selreports writer to use RawBank::View to Make all writers and decoders to use RawBank::View

added Persistency label

requested review from @graven

@mstahl Please note that this not meant to be merged with master.

resolved all threads

added 1 commit

• c699a5dd - fix lumi writer typo

Compare with previous version

added 1 commit

• dd91ea0e - add a check for RawBank type in decoders since View doesn't have type

Compare with previous version

added 16 commits

• 49a4b10f - Fix RichDetectors decoding ref logs for dd4hep
• 076a1037 - fix precision
• 0918e003 - Merge branch 'fix-rich-decode-refs-dd4hep' into 'master'
• 348e26cf - DD4hepSvc - Use debug() stream for 'debug' message
• 73252a8a - Merge branch 'use-debug-stream-for-debug' into 'master'
• b9287031 - Merge branch 'fix_retina_full_decoder_precision' into 'master'
• 84f697ba - Add 2 basic plume lumi counters to the lumi summary offsets
• 2ebab521 - Merge branch 'sxian_add_basic_plume_counters_to_LumiSumOffsets' into 'master'
• 04b27438 - Remove process keyword ambiguity
• 86961a60 - Merge branch 'SprucingDev' into 'master'
• e890ce25 - Hide 'write once, do not read' instance of RawEvent using a useless view
• bf50fffb - make routing bits and selreports writer to use RawBank::View
• 8c1ab8c9 - fix the location names for packed buffer writer
• e3ce81c5 - Make HltLumiWriter not to modify the event
• 3f049bf2 - fix lumi writer typo
• 54305a31 - add a check for RawBank type in decoders since View doesn't have type

Compare with previous version

added 1 commit

• d3536df1 - add an output to BackwardsCompatibleMergeViewIntoRawEvent.cpp

Compare with previous version

added 15 commits

• afab6c0c - Add non-const taggers() accessor
• 1e455ae6 - Merge branch 'add-non-const-taggers-accessor' into 'master'
• e7b5c0df - Revert "Merge branch 'sxian_add_basic_plume_counters_to_LumiSumOffsets' into 'master'"
• c0e8553d - Merge branch 'revert-2ebab521' into 'master'
• 1e2791b0 - Add lock to execute of MDFWriter and enable multi-threaded MDF writing
• 44ce1f31 - Merge branch 'mult_mdf_writer' into 'master'
• e7d4a4a7 - Add algorithm to combine hlt1 and hlt2 routing bits and rework RoutingBitsWriter
• 21b7b7fa - Merge branch 'routing_bits' into 'master'
• c5659b84 - Hide 'write once, do not read' instance of RawEvent using a useless view
• 7eef9372 - make routing bits and selreports writer to use RawBank::View
• 6832faac - fix the location names for packed buffer writer
• c787be78 - Make HltLumiWriter not to modify the event
• 26ecdd83 - fix lumi writer typo
• 15f55668 - add a check for RawBank type in decoders since View doesn't have type
• fbb89600 - add an output to BackwardsCompatibleMergeViewIntoRawEvent.cpp

Compare with previous version

added 1 commit

• 0499fb2c - fix for routing bits writer

Compare with previous version

added 10 commits

• f27d527a - Add an algorithm to monitor routing bits
• 3a95a855 - Merge branch 'rm-HltRoutingBitsMonitor' into 'master'
• cb0eaed3 - Hide 'write once, do not read' instance of RawEvent using a useless view
• 6090afa9 - make routing bits and selreports writer to use RawBank::View
• 74521481 - fix the location names for packed buffer writer
• 8aea7df4 - Make HltLumiWriter not to modify the event
• 2f28a566 - fix lumi writer typo
• 01e0e843 - add a check for RawBank type in decoders since View doesn't have type
• 83783b22 - add an output to BackwardsCompatibleMergeViewIntoRawEvent.cpp
• 561e2918 - fix for routing bits writer

Compare with previous version

added 1 commit

• 9d8e655a - undo changes to BackwardsCompatibleMergeViewIntoRawEvent.cpp

Compare with previous version

added 13 commits

• 67e82216 - skip raw bank in retina decoding if column is out of range
• 0782d743 - add generic forwarding of (some) functors in case of pointer argument
• a5cf98cc - Merge branch 'decianm-hotFixRetinaDecoding' into 'master'
• 3b346d69 - Merge branch 'generic_pointer_forwarding' into 'master'
• 22fd97e2 - Hide 'write once, do not read' instance of RawEvent using a useless view
• 802e5c2e - make routing bits and selreports writer to use RawBank::View
• 4c502acb - fix the location names for packed buffer writer
• becdd334 - Make HltLumiWriter not to modify the event
• bef5c1e9 - fix lumi writer typo
• 592b6ff2 - add a check for RawBank type in decoders since View doesn't have type
• c018de03 - add an output to BackwardsCompatibleMergeViewIntoRawEvent.cpp
• 06eed3f0 - fix for routing bits writer
• 70e17f85 - undo changes to BackwardsCompatibleMergeViewIntoRawEvent.cpp

Compare with previous version

changed target branch from issue-179 to master

added RTA label

mentioned in merge request Allen!1070 (merged)

marked this merge request as draft

changed the description

mentioned in merge request Moore!1900 (merged)

added 1 commit

• 9416a89c - make raw event read only for routing bits combiner

Compare with previous version

• [2022-11-23 11:42] Validation started with lhcb-master-mr#6358
• [2022-11-25 14:51] Validation started with lhcb-master-mr#6396
• [2022-11-28 16:59] Validation started with lhcb-master-mr#6428
• [2022-11-29 10:41] Validation started with lhcb-master-mr#6435

added 12 commits

• 9416a89c...d050e60c - 2 commits from branch master
• 43c30ab1 - Hide 'write once, do not read' instance of RawEvent using a useless view
• 4bef61e3 - make routing bits and selreports writer to use RawBank::View
• a8ddc4fe - fix the location names for packed buffer writer
• b25035b5 - Make HltLumiWriter not to modify the event
• 3dd89886 - fix lumi writer typo
• 59313a14 - add a check for RawBank type in decoders since View doesn't have type
• 289a7ed4 - add an output to BackwardsCompatibleMergeViewIntoRawEvent.cpp
• 0ea0cd9a - fix for routing bits writer
• a4b2b2bd - undo changes to BackwardsCompatibleMergeViewIntoRawEvent.cpp
• 97d720df - make raw event read only for routing bits combiner

Compare with previous version

mentioned in merge request MooreAnalysis!98 (merged)

added 14 commits

• 97d720df...7399101c - 4 commits from branch master
• 6b0d3f8c - Hide 'write once, do not read' instance of RawEvent using a useless view
• 1be5a81f - make routing bits and selreports writer to use RawBank::View
• 62fb7654 - fix the location names for packed buffer writer
• 98bb0dd8 - Make HltLumiWriter not to modify the event
• 32187646 - fix lumi writer typo
• fc8f8e6b - add a check for RawBank type in decoders since View doesn't have type
• 2e5fe680 - add an output to BackwardsCompatibleMergeViewIntoRawEvent.cpp
• ffbceb6c - fix for routing bits writer
• 92fd441c - undo changes to BackwardsCompatibleMergeViewIntoRawEvent.cpp
• cb6c90e9 - make raw event read only for routing bits combiner

Compare with previous version

changed the description

added 12 commits

• cb6c90e9...4b6a469e - 2 commits from branch master
• fb18ac25 - Hide 'write once, do not read' instance of RawEvent using a useless view
• e98a02e3 - make routing bits and selreports writer to use RawBank::View
• b48e2597 - fix the location names for packed buffer writer
• 62a1bf9f - Make HltLumiWriter not to modify the event
• fd688d1a - fix lumi writer typo
• 58116402 - add a check for RawBank type in decoders since View doesn't have type
• 55aa30b1 - add an output to BackwardsCompatibleMergeViewIntoRawEvent.cpp
• a1f0f1a2 - fix for routing bits writer
• e12b2ad7 - undo changes to BackwardsCompatibleMergeViewIntoRawEvent.cpp
• 54e4291d - make raw event read only for routing bits combiner

Compare with previous version

added 15 commits

• 54e4291d...165d37dd - 5 commits from branch master
• acc26c40 - Hide 'write once, do not read' instance of RawEvent using a useless view
• 46755354 - make routing bits and selreports writer to use RawBank::View
• 7dbf4ae4 - fix the location names for packed buffer writer
• 09cd1ae8 - Make HltLumiWriter not to modify the event
• 5a76548b - fix lumi writer typo
• decaed88 - add a check for RawBank type in decoders since View doesn't have type
• f4b2f9ff - add an output to BackwardsCompatibleMergeViewIntoRawEvent.cpp
• bf7387d8 - fix for routing bits writer
• 5f539714 - undo changes to BackwardsCompatibleMergeViewIntoRawEvent.cpp
• d4f69b08 - make raw event read only for routing bits combiner

Compare with previous version

mentioned in merge request !3390 (closed)

changed the description

added 17 commits

• d4f69b08...2317039f - 7 commits from branch master
• b2e54eb3 - Hide 'write once, do not read' instance of RawEvent using a useless view
• 322574fa - make routing bits and selreports writer to use RawBank::View
• a000b737 - fix the location names for packed buffer writer
• 64540395 - Make HltLumiWriter not to modify the event
• b0ae0e56 - fix lumi writer typo
• 36e3ad96 - add a check for RawBank type in decoders since View doesn't have type
• 9e2acf00 - add an output to BackwardsCompatibleMergeViewIntoRawEvent.cpp
• 54b5710f - fix for routing bits writer
• 4980e461 - undo changes to BackwardsCompatibleMergeViewIntoRawEvent.cpp
• 40a5b0b6 - make raw event read only for routing bits combiner

Compare with previous version

marked this merge request as ready

added 1 commit

• 0f9c8cca - fix lumi writer output

Compare with previous version

added 1 commit

• 7190c01c - remove LHCb namespace from HltLumiWriter

Compare with previous version

resolved all threads

• [2022-11-29 10:51] Validation started with lhcb-master-mr#6436
• [2022-11-29 12:45] Validation started with lhcb-master-mr#6438
• [2022-11-29 14:43] Validation started with lhcb-master-mr#6441

added 1 commit

• 053afb9b - remove using LHCb name space

Compare with previous version

added 19 commits

• 053afb9b...09e73591 - 6 commits from branch master
• 5958b82e - Hide 'write once, do not read' instance of RawEvent using a useless view
• dc324573 - make routing bits and selreports writer to use RawBank::View
• c4072c56 - fix the location names for packed buffer writer
• c47665b5 - Make HltLumiWriter not to modify the event
• 6273f3b9 - fix lumi writer typo
• e80e2e75 - add a check for RawBank type in decoders since View doesn't have type
• 3121b2a4 - add an output to BackwardsCompatibleMergeViewIntoRawEvent.cpp
• 0f570d0f - fix for routing bits writer
• afdfb12b - undo changes to BackwardsCompatibleMergeViewIntoRawEvent.cpp
• bae5fc43 - make raw event read only for routing bits combiner
• b4fd3001 - fix lumi writer output
• 24287c9e - remove LHCb namespace from HltLumiWriter
• 897ae458 - remove using LHCb name space

Compare with previous version

merged

mentioned in commit d5de63ea

changed the description

mentioned in issue #179 (closed)