Adapted to changes in BaseSink and Entities

Depends on gaudi/Gaudi!1439 (merged)

Goes together with Allen!1324 (merged) Online!823 (merged) Lbcom!682 (merged)

Addresses partially #294

In particular :

• Fixed clashing counter names now that we check them
• Inherit from BaseSink in PhoenixSink and simplify the code
• Rebased FSRSink on BaseSink and simplify it accordingly
• Simplified further FSRSink now that BaseSink has flushing features
• Dropped IncludeJobOptions property from FSRSink
• Better fix for ignoring nlohman unused functions

Note (by @clemenci): I reverted part of the changes in FSRSink as the new version changed too much the behaviour

mentioned in merge request Rec!3356 (closed)

changed the description

marked this merge request as draft

added RTA label

added 1 commit

• d78b0689 - Fixed formatting

Compare with previous version

mentioned in merge request Allen!1156 (merged)

changed the description

/ci-test gaudi/Gaudi!1439 (merged) Rec!3356 (closed) Allen!1156 (merged)

changed the description

added ci-test-triggered label

• [2023-03-21 17:15] Validation started with lhcb-master-mr#7401
• [2023-03-21 17:49] Validation started with lhcb-master-mr#7401
• [2023-03-21 18:22] Validation started with lhcb-master-mr#7401
• [2023-03-21 18:57] Validation started with lhcb-master-mr#7401
• [2023-03-22 09:16] Validation started with lhcb-master-mr#7403
• [2023-03-22 11:22] Validation started with lhcb-master-mr#7405
• [2023-03-31 15:13] Validation started with lhcb-master-mr#7510
• [2023-04-05 14:12] Validation started with lhcb-master-mr#7534

/ci-test gaudi/Gaudi!1439 (merged) Rec!3356 (closed) Allen!1156 (merged)

resolved all threads

added 21 commits

• d78b0689...e008ce58 - 12 commits from branch master
• 701d09eb - Better fix for ignoring nlohman unused functions
• e1eac2a2 - Rebased FSRSink on BaseSink and simplify it accordingly
• a7437a36 - Dropped IncludeJobOptions property from FSRSink
• 5d5b4a00 - Simplified further FSRSink now that BaseSink has flushing features
• db6d7f38 - Inherit from BaseSink in PhoenixSink and simply the code
• 893fd120 - Fixed clashing counter names now that we check them
• 64222f81 - Adapted to changes in BaseSink and Entities
• b2784e29 - Fixed formatting
• b8f2893b - Fixed LumiEventCounters, as they were added in parallel to this MR

Compare with previous version

resolved all threads

/ci-test gaudi/Gaudi!1439 (merged) Rec!3356 (closed) Allen!1156 (merged)

added 11 commits

• b8f2893b...05e81573 - 2 commits from branch master
• db8a6a52 - Better fix for ignoring nlohman unused functions
• 47b09869 - Rebased FSRSink on BaseSink and simplify it accordingly
• 0120d3fd - Dropped IncludeJobOptions property from FSRSink
• 1f177ca3 - Simplified further FSRSink now that BaseSink has flushing features
• 2f1e4b60 - Inherit from BaseSink in PhoenixSink and simply the code
• 86df5d71 - Fixed clashing counter names now that we check them
• 4c095027 - Adapted to changes in BaseSink and Entities
• 36473c42 - Fixed formatting
• 54f1b9be - Fixed LumiEventCounters, as they were added in parallel to this MR

Compare with previous version

added 1 commit

• 636f3cba - Fixed LumiEventCounters, as they were added in parallel to this MR

Compare with previous version

changed the description