Skip to content
Snippets Groups Projects

Make sure Git resources are released before git_libgit2_shutdown

Merged Marco Clemencic requested to merge fix-git-entity-resolver-segfault into master
All threads resolved!

It may happen (in some error condition) that finalize() is skipped, in which case the Git resources might not be released before ~GitEntityResolver, so it's important to ensure they are released to avoid a segfault.

The problem was exposed by gaudi/Gaudi!1432 (merged) because it changed the failure mode of a couple of tests in XMLSummaryKernel (see !4023 (merged)) and the new failure mode hit the corner case I'm fixing here.

/cc @sponce

Merge request reports

Merge request pipeline #5317193 passed

Merge request pipeline passed for 0c8c96b2

Approved by

Merged by Sebastien PonceSebastien Ponce 2 years ago (Mar 23, 2023 1:19pm UTC)

Merge details

  • Changes merged into master with 840dd648.
  • Deleted the source branch.

Pipeline #5318652 passed

Pipeline passed for 840dd648 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading