Skip to content
Snippets Groups Projects

add option to explicitly by-pass check for identically configured components with different names

Merged Gerhard Raven requested to merge allow-duplicates into master
All threads resolved!

Allow opt-out of checking for identical configured components with different names.

This will allow eg. multiple lines to have the identically configured up-front filters with their own distinct and dedicated name -- which will introduce a bit of overhead, but it makes things logically independent (and as they were in Run1 + Run2) and more stable under changes in configuration (i.e. the configuration of one line will not change just because another line with which it spuriously shared some component instance changed). Note that these clashes are typically 'spurious', i.e. there is just a large likelihood of multiple unrelated lines filtering on the same set of lines at a previous stage, without this being intentional, and without this having to be the case 'by construction'.

Note that the default behaviour remains to not allow this, and one has to explicitly 'opt-out' of this check.

Goes together with Moore!2336 (merged)

Edited by Gerhard Raven

Merge request reports

Merge request pipeline #5669656 passed

Merge request pipeline passed for 5644d0d4

Approved by

Merged by Sebastien PonceSebastien Ponce 1 year ago (Jun 3, 2023 7:32am UTC)

Merge details

  • Changes merged into master with f62b8355.
  • Deleted the source branch.

Pipeline #5676982 passed

Pipeline passed for f62b8355 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Gerhard Raven added 1 commit

    added 1 commit

    • 564d17c2 - explicitly add flag to by-pass check for identically configured components with different names

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • c5d79d69 - explicitly add flag to by-pass check for identically configured components with different names

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • e5044411 - explicitly add flag to by-pass check for identically configured components with different names

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 80b97e9a - explicitly add flag to by-pass check for identically configured components with different names

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 30a4a12d - explicitly add flag to by-pass check for identically configured components with different names

    Compare with previous version

  • Gerhard Raven mentioned in merge request Moore!1605 (merged)

    mentioned in merge request Moore!1605 (merged)

  • Gerhard Raven added 1 commit

    added 1 commit

    • fe8aede0 - explicitly add flag to by-pass check for identically configured components with different names

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 97dbf2ad - explicitly add flag to by-pass check for identically configured components with different names

    Compare with previous version

  • Edited by Software for LHCb
  • Gerhard Raven added 3 commits

    added 3 commits

    • 97dbf2ad...676abf33 - 2 commits from branch master
    • 8b9f2127 - explicitly add flag to by-pass check for identically configured components with different names

    Compare with previous version

  • Gerhard Raven added 5 commits

    added 5 commits

    • 8b9f2127...fac15526 - 4 commits from branch master
    • 4a8c3eeb - explicitly add flag to by-pass check for identically configured components with different names

    Compare with previous version

  • Gerhard Raven added 5 commits

    added 5 commits

    • 4a8c3eeb...9b4e8dcd - 4 commits from branch master
    • 5644d0d4 - explicitly add flag to by-pass check for identically configured components with different names

    Compare with previous version

  • assigned to @sponce

  • Gerhard Raven mentioned in merge request !4116 (merged)

    mentioned in merge request !4116 (merged)

  • Sebastien Ponce resolved all threads

    resolved all threads

  • mentioned in commit Allen@2685b052

  • mentioned in commit Moore@3074db90

  • mentioned in commit Panoptes@17cf0300

  • mentioned in commit Boole@a0b54de5

  • mentioned in merge request Alignment!381 (merged)

  • mentioned in merge request Panoptes!277 (closed)

  • mentioned in commit Alignment@07e95f59

  • mentioned in merge request Moore!2386 (merged)

  • Software for LHCb mentioned in merge request Boole!478 (closed)

    mentioned in merge request Boole!478 (closed)

  • mentioned in merge request Allen!1229 (closed)

  • mentioned in commit Moore@c45e22f5

  • Sebastien Ponce mentioned in commit f62b8355

    mentioned in commit f62b8355

  • mentioned in commit Moore@7946a307

  • mentioned in commit Alignment@c286be84

  • mentioned in commit Moore@efc4f95f

  • mentioned in commit Moore@47563ec2

  • mentioned in issue Moore#598 (closed)

  • Rosen Matev mentioned in merge request !4191 (merged)

    mentioned in merge request !4191 (merged)

  • Please register or sign in to reply
    Loading