Remove non-thread-safe unused code
All threads resolved!
All threads resolved!
Remove some algorithms that are non-thread-safe and unused (in Rec and Moore):
- MuonPIDsFromProtoParticlesAlg.cpp
- RichPIDsFromProtoParticlesAlg.cpp
Needs !4170 (merged) where obsolete tests using this code are removed
Towards Rec#411
Edited by Carla Marin Benito
Merge request reports
Activity
added cleanup label
assigned to @cmarinbe
added RTA label
mentioned in merge request Rec!3473 (merged)
- [2023-06-22 23:58] Validation started with lhcb-master-mr#8340
- [2023-07-03 22:23] Validation started with lhcb-master-mr#8451
- [2023-07-12 09:12] Validation started with lhcb-master-mr#8525
Edited by Software for LHCb- Resolved by Rosen Matev
This breaks the following tests in LHCb:
| IOExample.copymc10dsttoroot | PASS | FAIL | | IOExample.copyreco08dsttoroot | PASS | FAIL | | IOExample.copyreco12stripping17dsttoroot | PASS | FAIL | | IOExample.copyreco14stripping20dsttoroot | PASS | FAIL | | IOExample.readmc10rootdst | PASS | FAIL | | IOExample.readreco08rootdst | PASS | FAIL | | IOExample.readreco12stripping17dst | PASS | FAIL | | IOExample.readreco14stripping20dst | PASS | FAIL |
They all use
RichPIDsFromProtoParticlesAlg
and are probably obsolete in the master branch. @jonrob shall we just remove these tests from master or modernise them somehow?
mentioned in merge request !4170 (merged)
added ci-test-triggered label
assigned to @mzdybal
mentioned in commit 951c4902
mentioned in issue Moore#623 (closed)
Please register or sign in to reply