Fixes for gcc 13, clang 16 and C++20

• Fix implicit capture of this (deprecated in C++20)
• Fix (deprecated) implicit conversion from enum to float
• Avoid use of deprecated is_pod
• Replace unneeded enum with constexpr unsigned int
• Remove unused variables
• Fix implicit copy constructor/assignment deprecation warning
• Use && instead of & for booleans
• Hide null-pointer-subtraction warning
• Fix potential dereferencing of nullptr
• Hide warnings 'void operator delete(void*, std::size_t)' called on pointer '<unknown>' with nonzero offset from BernsteinPoly.cpp (probable false positive)
• Fix warning about unused functions (only in standalone build of public headers)
• Replace std::random_shuffle with std::shuffle (random_shuffle was deprecated in C++14 and should have been removed in C++17) moved to !4335 (merged)

Notes:

• when building *-gcc13-dbg platforms there are a number of spurious warnings in dictionaries, fixed by gaudi/Gaudi!1501 (merged)
• commit d8ad2fe3 (from random_shuffle to shuffle) requires a change in the reference files in Boole and Rec

added lhcb-gaudi-head label

added RTA label

• [2023-10-13 00:04] Validation started with lhcb-gaudi-head#3709
• [2023-10-13 12:02] Validation started with lhcb-gaudi-head#3710
• [2023-10-14 00:20] Validation started with lhcb-gaudi-head#3711
• [2023-10-14 08:22] Validation started with lhcb-gaudi-head#3712
• [2023-10-15 00:03] Validation started with lhcb-gaudi-head#3713
• [2023-10-17 00:04] Validation started with lhcb-gaudi-head#3714
• [2023-10-17 12:06] Validation started with lhcb-gaudi-head#3715
• [2023-10-18 00:35] Validation started with lhcb-gaudi-head#3716
• [2023-10-18 07:07] Validation started with lhcb-gaudi-head#3717
• [2023-10-19 00:04] Validation started with lhcb-gaudi-head#3718
• [2023-10-19 00:36] Validation started with lhcb-gaudi-head#3718
• [2023-10-19 07:17] Validation started with lhcb-gaudi-head#3719
• [2023-10-19 11:36] Validation started with lhcb-gaudi-head#3720
• [2023-10-19 14:17] Validation started with lhcb-master-mr#9494
• [2023-10-20 00:04] Validation started with lhcb-gaudi-head#3721
• [2023-10-20 00:37] Validation started with lhcb-gaudi-head#3721
• [2023-10-20 10:54] Validation started with lhcb-master-mr#9504
• [2023-10-21 00:04] Validation started with lhcb-gaudi-head#3722
• [2023-10-22 00:04] Validation started with lhcb-gaudi-head#3723
• [2023-10-24 00:04] Validation started with lhcb-gaudi-head#3724
• [2023-10-25 00:04] Validation started with lhcb-gaudi-head#3725
• [2023-10-26 00:04] Validation started with lhcb-gaudi-head#3726
• [2023-10-27 00:04] Validation started with lhcb-gaudi-head#3727
• [2023-10-28 00:04] Validation started with lhcb-gaudi-head#3728
• [2023-10-31 00:03] Validation started with lhcb-gaudi-head#3729

changed title from Draft: Fixes for gcc13 to Draft: Fixes for gcc13 and C++20

changed the description

added 3 commits

• c020d8bd - Fix (deprecated) arithmetic between enumeration type and floating-point type
• 57904bfc - Avoid use of deprecated is_pod
• c31ec20d - Replace unneeded enum with constexpr int

Compare with previous version

added 5 commits

• d8677299 - Remove unused variables
• e8a783c2 - Fix implicit copy constructor/assignment deprecation warning
• 6c64b324 - fixup! Remove unused variables
• b831dee9 - Use && instead of & for booleans
• 075c989b - Hide null-pointer-subtraction warning

Compare with previous version

added 4 commits

• ba1e5734 - Remove unused variables
• 53aa59ae - Fix implicit copy constructor/assignment deprecation warning
• cf049f4a - Use && instead of & for booleans
• 2bb82d7e - Hide null-pointer-subtraction warning

Compare with previous version

changed title from Draft: Fixes for gcc13 and C++20 to Draft: Fixes for gcc 13, clang 16 and C++20

changed the description

added 4 commits

• 88b510dc - Remove unused variables
• 61e97a3b - Fix implicit copy constructor/assignment deprecation warning
• 45abf9b8 - Use && instead of & for booleans
• 59ddb949 - Hide null-pointer-subtraction warning

Compare with previous version

added 4 commits

• 772f1422 - Fix dereferencing of nullptr
• 5688057c - Suppress warning from BernsteinPoly.cpp (gcc13)
• a750de95 - Fix Clang warning about unused functions
• 27961150 - Replace std::random_shuffle with std::shuffle

Compare with previous version

changed the description

added 20 commits

• 27961150...78b659b7 - 8 commits from branch master
• 78b659b7...b5765f72 - 2 earlier commits
• 0b8e0f56 - Avoid use of deprecated is_pod
• c1831bbf - Replace unneeded enum with constexpr int
• cea13ade - Remove unused variables
• ba7071f0 - Fix implicit copy constructor/assignment deprecation warning
• 22a4a926 - Use && instead of & for booleans
• facc262d - Hide null-pointer-subtraction warning
• 06840d6f - Fix dereferencing of nullptr
• 637b505f - Suppress warning from BernsteinPoly.cpp (gcc13)
• 386f34ba - Fix Clang warning about unused functions
• 89a151f6 - Replace std::random_shuffle with std::shuffle

Compare with previous version

added 1 commit

• 9079929a - Hide maybe-uninitialized warning from Vc

Compare with previous version

added 19 commits

• 9079929a...1ecddf03 - 6 commits from branch master
• 1ecddf03...87171a48 - 3 earlier commits
• 10b0d513 - Replace unneeded enum with constexpr int
• 69aa2b1d - Remove unused variables
• 2d2b2e78 - Fix implicit copy constructor/assignment deprecation warning
• e22f8185 - Use && instead of & for booleans
• 0571bd8f - Hide null-pointer-subtraction warning
• 55678604 - Fix dereferencing of nullptr
• 53b22872 - Suppress warning from BernsteinPoly.cpp (gcc13)
• 33e4e24f - Fix Clang warning about unused functions
• d8ad2fe3 - Replace std::random_shuffle with std::shuffle
• 723a61ca - Hide maybe-uninitialized warning from Vc

Compare with previous version

marked this merge request as ready

I have a number of technical (code clean up and fixes) that are needed to be able to switch to LCG 104. Although they are uncorrelated, I prefer to trigger one single ci-test job here

/ci-test Run2Support!51 (merged) Online!911 (merged) Allen!1362 (merged) Rec!3626 (merged) Lbcom!700 (merged) Detector!445 (merged) MooreAnalysis!129 (merged) !4317 (merged) !4316 (merged) Rec!3617 (merged)