Skip to content
Snippets Groups Projects

Pass "type/name" to scheduler (fixes warnings)

Merged Rosen Matev requested to merge rm-fix-broker-warnings into master

IDataBroker::algorithmsRequiredFor has this unfortunate interface where TypeNameString is implicitly convertible from a string. Passing "abc" is equivalent to "abc/abc" which doesn't always make sense especially since the implementation in HiveDataBroker explicitly checks TypeNameString::type() for consistency.

  virtual std::vector<Gaudi::Algorithm*>
  algorithmsRequiredFor( const Gaudi::Utils::TypeNameString& alg,
                         const std::vector<std::string>&     stoppers = {} ) const = 0;

Here the usage of the interface is improved.

/cc @graven

Merge request reports

Merge request pipeline #6347146 passed

Merge request pipeline passed for 934e88e9

Approval is optional

Merged by Rosen MatevRosen Matev 1 year ago (Oct 17, 2023 8:42pm UTC)

Merge details

  • Changes merged into with 3c94d3d5.
  • Deleted the source branch.

Pipeline #6352505 passed

Pipeline passed for 3c94d3d5 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading