Skip to content
Snippets Groups Projects

consistently use LHCb::span instead of gsl::span

Merged Gerhard Raven requested to merge gsl-span-fixes into 2024-patches
All threads resolved!

avoid mixing LHCb::span (which defers to gsl::span) and direct use of gsl::span, as LHCb::span makes sure several macros are defined to avoid bounds checking in non-debug builds, and ensures that span<byte> uses std::byte instead of gsl::byte, and we don't want to have two 'variants' of gsl::span being used simultaneously which are configured differently...

(and it will make a future migration to C++20 std::span easier as well)

Closes #351 (closed)

Edited by Andre Gunther

Merge request reports

Merge request pipeline #7271988 passed

Merge request pipeline passed for 8103290e

Approval is optional

Merged by Christopher Rob JonesChristopher Rob Jones 11 months ago (Apr 24, 2024 8:25am UTC)

Merge details

  • Changes merged into 2024-patches with 65e6047d (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Andre Gunther
  • Andre Gunther changed the description

    changed the description

  • Andre Gunther mentioned in merge request !4527 (merged)

    mentioned in merge request !4527 (merged)

  • assigned to @jonrob

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 25 commits

    Compare with previous version

  • Christopher Rob Jones resolved all threads

    resolved all threads

  • Christopher Rob Jones resolved all threads

    resolved all threads

  • mentioned in commit 65e6047d

  • Marco Clemencic mentioned in merge request !4539 (merged)

    mentioned in merge request !4539 (merged)

  • Please register or sign in to reply
    Loading