Disable Boost pool allocators

mentioned in merge request Rec!607 (merged)

added 3 commits

46c8bc2b...5ea15caf - 2 commits from branch master
734ac532 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/LHCb into DisablePoolAllocators

[2017-06-03 00:02] Validation started with lhcb-gaudi-head#1491
[2017-06-04 00:03] Validation started with lhcb-gaudi-head#1492
[2017-06-05 00:03] Validation started with lhcb-gaudi-head#1493
[2017-06-06 00:03] Validation started with lhcb-gaudi-head#1494
[2017-06-07 00:03] Validation started with lhcb-gaudi-head#1495
[2017-06-08 00:03] Validation started with lhcb-gaudi-head#1496
[2017-06-09 00:08] Validation started with lhcb-gaudi-head#1497
[2017-06-10 00:03] Validation started with lhcb-gaudi-head#1498
[2017-06-11 00:03] Validation started with lhcb-gaudi-head#1499
[2017-06-12 00:07] Validation started with lhcb-gaudi-head#1500
[2017-06-13 00:06] Validation started with lhcb-gaudi-head#1501
[2017-06-14 00:04] Validation started with lhcb-gaudi-head#1502
[2017-06-15 00:03] Validation started with lhcb-gaudi-head#1503
[2017-06-16 00:04] Validation started with lhcb-gaudi-head#1504
[2017-06-17 00:04] Validation started with lhcb-gaudi-head#1505
[2017-06-18 00:04] Validation started with lhcb-gaudi-head#1506
[2017-06-19 00:04] Validation started with lhcb-gaudi-head#1507
[2017-06-20 00:04] Validation started with lhcb-gaudi-head#1508
[2017-06-21 00:03] Validation started with lhcb-gaudi-head#1509
[2017-06-21 00:23] Validation started with lhcb-gaudi-head#1509
[2017-06-21 00:45] Validation started with lhcb-gaudi-head#1509
[2017-06-21 01:54] Validation started with lhcb-gaudi-head#1509
[2017-06-22 00:04] Validation started with lhcb-gaudi-head#1510
[2017-06-24 00:03] Validation started with lhcb-gaudi-head#1512
[2017-06-25 00:03] Validation started with lhcb-gaudi-head#1513
[2017-06-26 00:04] Validation started with lhcb-gaudi-head#1514
[2017-06-27 00:03] Validation started with lhcb-gaudi-head#1515
[2017-06-28 00:03] Validation started with lhcb-gaudi-head#1516
[2017-06-29 00:03] Validation started with lhcb-gaudi-head#1517
[2017-06-30 00:03] Validation started with lhcb-gaudi-head#1518
[2017-07-01 00:04] Validation started with lhcb-gaudi-head#1519
[2017-07-02 00:04] Validation started with lhcb-gaudi-head#1520
[2017-07-03 00:04] Validation started with lhcb-gaudi-head#1521
[2017-07-04 00:04] Validation started with lhcb-gaudi-head#1522
[2017-07-05 00:04] Validation started with lhcb-gaudi-head#1523
[2017-07-06 00:05] Validation started with lhcb-gaudi-head#1524
[2017-07-07 00:05] Validation started with lhcb-gaudi-head#1525
[2017-07-07 09:03] Validation started with lhcb-gaudi-head#1525
[2017-07-08 00:04] Validation started with lhcb-gaudi-head#1526
[2017-07-09 00:03] Validation started with lhcb-gaudi-head#1527
[2017-07-10 00:04] Validation started with lhcb-gaudi-head#1528
[2017-07-12 18:13] Validation started with lhcb-gaudi-head#720
[2017-07-13 00:04] Validation started with lhcb-gaudi-head#1531
[2017-07-14 00:04] Validation started with lhcb-gaudi-head#1532
[2017-07-15 00:04] Validation started with lhcb-gaudi-head#1533
[2017-07-16 00:04] Validation started with lhcb-gaudi-head#1534
[2017-07-17 00:04] Validation started with lhcb-gaudi-head#1535
[2017-07-18 00:04] Validation started with lhcb-gaudi-head#1536
[2017-07-19 00:03] Validation started with lhcb-gaudi-head#1537
[2017-07-20 00:03] Validation started with lhcb-gaudi-head#1538
[2017-07-21 00:04] Validation started with lhcb-gaudi-head#1539
[2017-07-22 00:03] Validation started with lhcb-gaudi-head#1540
[2017-07-23 00:04] Validation started with lhcb-gaudi-head#1541
[2017-07-24 00:04] Validation started with lhcb-gaudi-head#1542
[2017-07-25 00:04] Validation started with lhcb-gaudi-head#1543
[2017-07-26 00:05] Validation started with lhcb-gaudi-head#1544
[2017-07-27 00:03] Validation started with lhcb-gaudi-head#1545
[2017-07-28 00:04] Validation started with lhcb-gaudi-head#1546
[2017-07-29 00:04] Validation started with lhcb-gaudi-head#1547
[2017-07-30 00:04] Validation started with lhcb-gaudi-head#1548
[2017-07-31 00:04] Validation started with lhcb-gaudi-head#1549
[2017-08-01 00:02] Validation started with lhcb-master#127
[2017-08-01 08:53] Validation started with lhcb-nightly-builds-test#375
[2017-08-01 14:53] Validation started with lhcb-nightly-builds-test#376
[2017-08-01 16:23] Validation started with lhcb-nightly-builds-test#377
[2017-08-02 00:03] Validation started with lhcb-nightly-builds-test#378
[2017-08-02 00:03] Validation started with lhcb-master#128
[2017-08-03 00:03] Validation started with lhcb-master#129
[2017-08-03 00:03] Validation started with lhcb-nightly-builds-test#379
[2017-08-04 00:03] Validation started with lhcb-master#130
[2017-08-04 00:04] Validation started with lhcb-nightly-builds-test#380
[2017-08-05 00:03] Validation started with lhcb-nightly-builds-test#381
[2017-08-05 00:04] Validation started with lhcb-master#131
[2017-08-06 00:03] Validation started with lhcb-nightly-builds-test#382
[2017-08-06 00:03] Validation started with lhcb-master#132
[2017-08-07 00:03] Validation started with lhcb-nightly-builds-test#383
[2017-08-07 00:03] Validation started with lhcb-master#133
[2017-08-08 00:03] Validation started with lhcb-master#134
[2017-08-08 00:03] Validation started with lhcb-nightly-builds-test#384
[2017-08-09 00:04] Validation started with lhcb-nightly-builds-test#385
[2017-08-09 00:04] Validation started with lhcb-master#135
[2017-08-10 00:03] Validation started with lhcb-master#136
[2017-08-10 00:03] Validation started with lhcb-nightly-builds-test#386
[2017-08-11 00:03] Validation started with lhcb-nightly-builds-test#387
[2017-08-11 00:04] Validation started with lhcb-master#137
[2017-08-12 00:03] Validation started with lhcb-nightly-builds-test#388
[2017-08-12 00:04] Validation started with lhcb-master#138
[2017-08-13 00:03] Validation started with lhcb-nightly-builds-test#389
[2017-08-13 00:03] Validation started with lhcb-master#139
[2017-08-14 00:03] Validation started with lhcb-nightly-builds-test#390
[2017-08-14 00:03] Validation started with lhcb-master#140
[2017-08-14 10:08] Validation started with lhcb-nightly-builds-test#390
[2017-08-14 10:08] Validation started with lhcb-master#140
[2017-08-15 00:03] Validation started with lhcb-nightly-builds-test#391
[2017-08-15 00:04] Validation started with lhcb-master#141
[2017-08-16 00:03] Validation started with lhcb-master#142
[2017-08-16 00:04] Validation started with lhcb-nightly-builds-test#392
[2017-08-17 00:04] Validation started with lhcb-master#143
[2017-08-17 00:04] Validation started with lhcb-nightly-builds-test#393
[2017-08-18 00:03] Validation started with lhcb-master#144
[2017-08-19 00:03] Validation started with lhcb-nightly-builds-test#395
[2017-08-19 00:03] Validation started with lhcb-head#1571
[2017-08-19 00:04] Validation started with lhcb-master#145
[2017-08-19 00:04] Validation started with lhcb-gaudi-head#1569
[2017-08-19 00:04] Validation started with lhcb-clang-test#679
[2017-08-19 00:04] Validation started with lhcb-gaudi-head-noavx#105
[2017-08-19 00:05] Validation started with lhcb-gaudi-head-noavx2#86
[2017-08-19 00:05] Validation started with lhcb-lcg-dev3#255
[2017-08-19 00:05] Validation started with lhcb-lcg-dev4#255
[2017-08-20 00:03] Validation started with lhcb-head#1572
[2017-08-20 00:03] Validation started with lhcb-master#146
[2017-08-20 00:03] Validation started with lhcb-nightly-builds-test#396
[2017-08-20 00:04] Validation started with lhcb-lcg-dev4#256
[2017-08-20 00:04] Validation started with lhcb-clang-test#680
[2017-08-20 00:04] Validation started with lhcb-gaudi-head-noavx2#87
[2017-08-20 00:04] Validation started with lhcb-gaudi-head#1570
[2017-08-21 00:04] Validation started with lhcb-master#147
[2017-08-21 00:04] Validation started with lhcb-nightly-builds-test#397
[2017-08-22 00:03] Validation started with lhcb-nightly-builds-test#398
[2017-08-22 00:04] Validation started with lhcb-master#148
[2017-08-23 00:03] Validation started with lhcb-nightly-builds-test#399
[2017-08-23 00:03] Validation started with lhcb-master#149
[2017-08-24 00:04] Validation started with lhcb-master#150
[2017-08-24 00:04] Validation started with lhcb-nightly-builds-test#400
[2017-08-25 00:04] Validation started with lhcb-master#151
[2017-08-25 00:04] Validation started with lhcb-nightly-builds-test#401
[2017-08-26 00:04] Validation started with lhcb-nightly-builds-test#402
[2017-08-26 00:04] Validation started with lhcb-master#152
[2017-08-27 00:03] Validation started with lhcb-nightly-builds-test#403
[2017-08-28 00:03] Validation started with lhcb-master#154
[2017-08-28 00:03] Validation started with lhcb-nightly-builds-test#404
[2017-08-29 00:03] Validation started with lhcb-master#155
[2017-08-29 00:03] Validation started with lhcb-nightly-builds-test#405
[2017-08-30 00:04] Validation started with lhcb-master#156
[2017-08-30 00:04] Validation started with lhcb-nightly-builds-test#406
[2017-08-31 00:03] Validation started with lhcb-master#157
[2017-08-31 00:03] Validation started with lhcb-nightly-builds-test#407
[2017-09-01 00:04] Validation started with lhcb-master#158
[2017-09-01 00:05] Validation started with lhcb-nightly-builds-test#408
[2017-09-02 00:05] Validation started with lhcb-nightly-builds-test#409
[2017-09-03 00:04] Validation started with lhcb-nightly-builds-test#410
[2017-09-03 00:04] Validation started with lhcb-master#160
[2017-09-04 00:03] Validation started with lhcb-master#161
[2017-09-04 00:04] Validation started with lhcb-nightly-builds-test#411
[2017-09-05 00:03] Validation started with lhcb-nightly-builds-test#412
[2017-09-05 00:03] Validation started with lhcb-master#162
[2017-09-06 00:04] Validation started with lhcb-master#163
[2017-09-06 00:04] Validation started with lhcb-nightly-builds-test#413
[2017-09-07 00:02] Validation started with lhcb-nightly-builds-test#414
[2017-09-07 00:03] Validation started with lhcb-master#164
[2017-09-08 00:03] Validation started with lhcb-master#165
[2017-09-08 00:04] Validation started with lhcb-nightly-builds-test#415
[2017-09-09 00:03] Validation started with lhcb-nightly-builds-test#416
[2017-09-09 00:03] Validation started with lhcb-master#166
[2017-09-10 00:03] Validation started with lhcb-master#167
[2017-09-10 00:03] Validation started with lhcb-nightly-builds-test#417
[2017-09-11 00:03] Validation started with lhcb-master#168
[2017-09-11 00:03] Validation started with lhcb-nightly-builds-test#418
[2017-09-12 00:03] Validation started with lhcb-nightly-builds-test#419
[2017-09-12 00:03] Validation started with lhcb-master#169
[2017-09-13 00:03] Validation started with lhcb-master#170
[2017-09-13 00:03] Validation started with lhcb-nightly-builds-test#420
[2017-09-14 00:03] Validation started with lhcb-nightly-builds-test#421
[2017-09-14 00:04] Validation started with lhcb-master#171
[2017-09-15 00:03] Validation started with lhcb-master#172
[2017-09-15 00:03] Validation started with lhcb-nightly-builds-test#422
[2017-09-16 00:03] Validation started with lhcb-nightly-builds-test#423
[2017-09-16 00:04] Validation started with lhcb-master#173
[2017-09-17 00:04] Validation started with lhcb-master#174
[2017-09-17 00:04] Validation started with lhcb-nightly-builds-test#424
[2017-09-18 00:03] Validation started with lhcb-master#175
[2017-09-18 00:04] Validation started with lhcb-nightly-builds-test#425
[2017-09-19 00:03] Validation started with lhcb-master#176
[2017-09-19 00:05] Validation started with lhcb-nightly-builds-test#426
[2017-09-20 00:02] Validation started with lhcb-nightly-builds-test#427
[2017-09-20 00:03] Validation started with lhcb-master#177
[2017-09-21 00:04] Validation started with lhcb-master#178
[2017-09-21 00:04] Validation started with lhcb-nightly-builds-test#428
[2017-09-22 00:03] Validation started with lhcb-master#179
[2017-09-22 00:05] Validation started with lhcb-nightly-builds-test#429
[2017-09-23 00:04] Validation started with lhcb-master#180
[2017-09-23 00:05] Validation started with lhcb-nightly-builds-test#430
[2017-09-24 00:05] Validation started with lhcb-nightly-builds-test#431
[2017-09-24 00:05] Validation started with lhcb-master#181
[2017-09-25 00:03] Validation started with lhcb-nightly-builds-test#432
[2017-09-25 00:04] Validation started with lhcb-master#182
[2017-09-26 00:04] Validation started with lhcb-nightly-builds-test#433
[2017-09-26 00:04] Validation started with lhcb-master#183
[2017-09-27 02:56] Validation started with lhcb-master#184
[2017-09-27 03:01] Validation started with lhcb-nightly-builds-test#434
[2017-09-28 00:04] Validation started with lhcb-master#185
[2017-09-28 00:04] Validation started with lhcb-nightly-builds-test#435
[2017-09-29 00:03] Validation started with lhcb-nightly-builds-test#436
[2017-09-29 00:04] Validation started with lhcb-master#186
[2017-09-30 00:04] Validation started with lhcb-nightly-builds-test#437
[2017-09-30 00:05] Validation started with lhcb-master#187
[2017-10-01 00:05] Validation started with lhcb-master#188
[2017-10-01 00:05] Validation started with lhcb-nightly-builds-test#438
[2017-10-02 00:04] Validation started with lhcb-master#189
[2017-10-02 00:04] Validation started with lhcb-nightly-builds-test#439
[2017-10-03 00:03] Validation started with lhcb-master#190
[2017-10-03 00:04] Validation started with lhcb-nightly-builds-test#440
[2017-10-04 00:04] Validation started with lhcb-master#191
[2017-10-04 00:06] Validation started with lhcb-nightly-builds-test#441
[2017-10-05 00:05] Validation started with lhcb-master#192
[2017-10-05 00:05] Validation started with lhcb-nightly-builds-test#442
[2017-10-06 00:04] Validation started with lhcb-master#193
[2017-10-06 00:04] Validation started with lhcb-nightly-builds-test#443
[2017-10-07 00:06] Validation started with lhcb-nightly-builds-test#444
[2017-10-07 00:06] Validation started with lhcb-master#194

@roiser Could you take a look at the GOD LHCb QM test failure this MR seems to be causing ? I am not sure why its happening.

added 12 commits

734ac532...bbd0a913 - 10 commits from branch master
01c93082 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/LHCb into DisablePoolAllocators
981869a3 - Update aalocator default to 'NO' for test

Compare with previous version

OK, I think I have fixed the test. Lets see tomorrow.

Just to comment here, this MR is awaiting feedback from the PR on the impact of the Moore rate tests.

@raaij @rmatev @sstahl @bcouturi @maszyman

added 90 commits

981869a3...a38c9ab1 - 89 commits from branch master
bfbf46a9 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/LHCb into DisablePoolAllocators

Compare with previous version

Just pinging this MR to remind people it is effectively on hold pending feedback from the HLT.

@jonrob I think this MR (and the corresponding one in Rec) is now the only one (apart from eventual differences in Gaudi) that could be causing differences in stdout in the Brunel tests in lhcb-gaudi-head - I am looking at https://lbnightlies.cern.ch/logs/tests/nightly/lhcb-gaudi-head/1528/x86_64-slc6-gcc62-opt/Brunel/ and comparing with the corresponding platform on lhcb-head, which is fully green (ignore the Wrong Counters errors, due to new tests functionality available in the next Gaudi release)

I think we should get to the bottom of this. Unless you have other ideas, I would start by temporarily removing the lhcb-gaudi-head label from this request (and the Rec one), to see if this is the cause of the test differences

I'm not sure I see how this MR could cause those diffs, but I agree we should get to the bottom of it. By all means remove the labels here to see if they go away..

@jonrob I am afraid we have a smoking gun. Without this MR (and the related Rec one) the Brunel tests in lhcb-head and lhcb-gaudi-head are identical, in particular for x86_64-slc6-gcc62-opt they are all green, as expected. I am putting back the lhcb-gaudi-head label to allow debugging....

Hmmm... The only way I can see these MRs having an effect is if somewhere this is some behaviour, like sorting, that is based on memory location, as that is really the only thing that can be affected. Also note just because the diffs are only seen in the RICH tables does not necessarily mean the issue is there. Could quite easily be in the tracking for instance. A number of tracking related classes are also touched by this...

The diffs are only in the Upgrade tests if I see that correctly? Isn't the RICH part almost identical for Upgrade and current detector? Then this hints more to the tracking part.

Good point. Yes, the RICH sequence is the same in both. Also note worthy is the fact we see similar diffs with the old and new RICH sequences. These are completely different algorithms, and the new sequence in fact hardly uses the pool allocators, by design. If I had to guess, I would indeed start with looking for something in the upgrade tracking that is doing something it should not based on memory addresses.

The failures are not just in the upgrade tests. The following tests are affected:

brunel-mc11a-xdst unexpected Wrong Counters
brunel-upgrade-baseline-oldrich unexpected standard output
brunel-upgrade-baseline unexpected standard output
repro2012reco14skiptracking unexpected standard output, Wrong Counters
vectorfit-brunel-upgrade-baseline unexpected standard output

See https://lbnightlies.cern.ch/logs/tests/nightly/lhcb-gaudi-head/1531/x86_64-slc6-gcc62-opt/Brunel/

In particular, repro2012reco14skiptracking does not rerun the tracking, so tracking cannot be the only culprit...

In fact, the diffs in repro2012reco14skiptracking seem due to RichTrackSegmen seeing a different number of tracks:

(RichTrackSegmen ref) "Number of states added" | 152 | 13635 | 89.704 | 72.528 | 3.0000 | 359.00
(RichTrackSegmen new) "Number of states added" | 152 | 13639 | 89.730 | 72.587 | 3.0000 | 359.00
(RichTrackSegmen ref) "Number of tracks seen" | 165 | 3449 | 20.903 | 18.604 | 0.0000 | 91.000
(RichTrackSegmen new) "Number of tracks seen" | 165 | 3450 | 20.909 | 18.618 | 0.0000 | 91.000

Which then leads to:

- RichRecoStatsDown    INFO               2953.42 +- 4.24 Rich1Gas  photons/event             
+ RichRecoStatsDown    INFO               2953.21 +- 4.24 Rich1Gas  photons/event

Disable Boost pool allocators

Merge request reports

Activity