Modernize MuonDAQ
- remove
private
methods from IMuonRawBuffer interface (as they cannot be called through the interface anyway!) - add some
const
in IMuonRawBuffer interface - prefer std::array over C-style arrays (to avoid decay into pointers, which loose the information on the size of the array)
- prefer zero initialization of array over .fill(0)
- make operator<< friend, in class scope, instead of in global scope
- make static constants constexpr
- prefer inherited constructors
- prefer switch/case over if-then
- prefer range-based loops
- prefer Gaudi::Property with direct member initialization over declareProperty
- reduce scope of variables as much as possible: only declare variables at the point they can be assigned a value
- prefer .fill(0) for arrays over explicit loops
- use lambda to consolidate repeated code
- simplify a few arithmetic expressions
- prefer STL algorithms over raw loops
- use a scoped guard over explicitly grouped 'set/reset' calls
- prefer std::bitset over arrays of bool