Warn about configuration of public tools through arguments
It seems that a PublicToolHandle
is not configurable through an argument to the constructor, such that any configuration of the tool seemingly done is actually void. Concretely, here we configure the IdealStateCreator (which is a public ToolHandle in a baseclass of the TrackResChecker), but this configuration is completely overwritten by the default values (including an empty default location for the linker tables). That overwrite only becomes visible when running over events, gaudirun.py --all-opts -n -o
will not show this. Changing the ToolHandle from public to private fixes the problem.
I suggest that we warn the user directly that one is trying to alter a public tool via the wrong way.
Including @chasse
Edited by Alex Pearce