rename composable
this is an artifact, the name should be something in the direction of make_configurable
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Niklas Stefan Nolte mentioned in merge request !187 (merged)
mentioned in merge request !187 (merged)
- Maintainer
That name makes things more clear.
- Maintainer
Agreed. A docstring on that method would also be helpful.
- Maintainer
you mean
make_algorithm
andmake_tool
? Collapse replies - Author Contributor
haven't made up my mind yet. it does not actually make an algorithm
it makes a maker of algorithms... So technically, it would bemake_make_algorithm
Edited by Niklas Stefan Nolte - Maintainer
do you like
make_Algorithm
more :Dmaybe that line of logic is pushing it too much. The function in question makes a new callable, which when called gives an instance. The instance is an algorithm (instance) but the callable is also an algorithm (if you think about it as class-like)
tl;dr I vote for
make_algorithm
Edited by Rosen Matev - Author Contributor
i thought you don't like abstracting (tl;dr'ing) single lines
will change tomake_algorithm
,make_tool
- Alex Pearce mentioned in commit 39ee1806
mentioned in commit 39ee1806
- Alex Pearce closed via merge request !187 (merged)
closed via merge request !187 (merged)
- Rosen Matev mentioned in commit LHCb@6c9511b2
mentioned in commit LHCb@6c9511b2