RTA Shift Summary 08/11/2021 - 22/11/2021
RTA shifter: Alessandro Scarabotto (@ascarabo)
RTA maintainer: Rosen Matev (@rmatev), Sebastien Ponce (@sponce)
Shift period: 08/11/2021 - 22/11/2021
Next shifter: Lorenzo Pica (@lpica)
Hello! Sorry I won't be able Monday to participate to shift handover chat. Just as a main comment: now the Allen pipeline is fixed so you can merge all those Allen MRs that were waiting for a ref update from the pipeline. Other than that @lpica you can have a look at my Google doc https://docs.google.com/spreadsheets/d/1W8Z3GxA-Snw1RzKeYqRSfXshpoQa60YPROEKIH5BdKQ/edit#gid=495308620 . If you want to use, you can for sure duplicate it and start from there (if you don't know how to use, message me on Mattermost).
Open MRs
| Description | MR(s) | Status | Next Action |
|---|---|---|---|
| Calo Clusters, Photon Line and min ADC Calo line | Allen!697 (closed), Allen!683 (merged) | changes to be done (index problem) | test them together when ready |
| speed up thor selections with fast distancecalculator | !1055 (closed) | address comments | test and ref update |
| Converted TrackMuonUpgradeAlg Class to Functional Framework | Alignment!220 (merged) | not urgent to merge | ask to add test? |
| make MuonID in hlt2 functional | !1141 (merged), Rec!2605 (merged), LHCb!3306 (merged) | address comments | test |
| Ks-Line | Allen!551 (merged) | Allen pipeline now works | rebase, ref update, test |
| Assorted CI improvements | Allen!583 (closed) | too old (create new MR) | test pipeline |
| Clustering for UT TELL40 decoding | Allen!607 (closed) | Moore MR in WIP | when un-WIP test together |
| DD4Hep implementation of FT | Rec!2562 (merged), LHCb!3264 (merged), Allen!698 (merged) | work ongoing by Louis | when ready test |
| CI: Add a throughput job with contracts enabled | Allen!663 (merged) | problems to be fix | run pipeline and see |
| 3 body vertex fitter | Allen!422 (closed) | rebase first | test |
| track-based electron shower algorithm for improved electron PID | !901 (merged), Rec!2319 (merged) | work ongoing (draft) | test |
| Implement 2D measurements | Rec!2140 (merged), !983 (merged), Alignment!208 (merged) | work ongoing (draft) | test |
| Modernize MuonDet | LHCb!3188 (closed) | suggestion to proceed and merge | merge? |
| Clean up logic for customising PyConf.Algorithm outputs | LHCb!3182 (merged) | tests look good | you can merge Rosen |
| Add v7 FT decoding | LHCb!2942 (merged) | draft | test |
| Check for warnings during CUDA builds in CI | Allen!669 (merged) | pipeline looks good | you can merge Rosen |
| TrackMonitor and TrackVertexMonitor renewal | Rec!2565 (merged), LHCb!3324 (merged) | test the 2 together | merge? |
| New Event Data Algorithms | Rec!2537 (merged) | waiting for 2 other MRs | test |
| Add v7 FT decoding | LHCb!2942 (merged) | draft | test |
| RetinaClusters decoding | Allen!655 (merged) | need to change MC for tests | solve problems first |
| RD common builders in the ThOr framework | !1150 (merged) | comments to be addressed | test |
| Kstarmumu HLT2 lin | !1040 (merged) | comments to be addressed | test |
| Potentially fix bug in configuration of TrackResChecker | !1015 (merged) | ping | ask status |
| RICH 1 alignment line | Allen!687 (merged) | ready to merge | merge |
| B2CC: Migration to ThOr functors | !1070 (merged) | work ongoing | test |
| Replace deprecated ToolHandle constuctor in MergedPi0 | Rec!2606 (merged) | ci-test launched | look at results |
| Generate automatically StructToTuple.cuh as part of build | Allen!621 (merged) | problems with build | test again? |
| Simple SV fit improvements | Allen!639 (merged) | rebase, launch pipeline | update ref and merge |
| Use Gaudi::Units::MeV in Properties | Allen!703 (merged) | rebase, launch pipeline | update ref and merge |
| Create Allen run configuration for Allen wrappers | !609 (merged) | comments to be addressed | test |
| Remove option to build without Allen | !1149 (merged) | ready to merge? | maybe test first |
| Updating SL lines with ThOr functors and adding new lines | !1151 (merged) | look at results of ci-test | test again |
| Replace activation functions with faster versions and moving to floats in PID | Rec!2611 (merged), !1157 (merged), Brunel!1179 (merged) | work ongoing | when ready, test and replace these 2 ref updates (maybe?) |
| New methods for PrFitNode + PrKalmanFilter as library and module | Rec!2603 (merged) | discussion ongoing | test |
| Initialise covariance with hit errors in VeloKalman | Rec!2612 (merged), Allen!705 (closed) | errors on test | test again |
| Temporary workaround to be able to use PatPV3D in default and fastest reconstruction | !1152 (merged) | ci-test (didn't work? maybe launch again) | merge |
| DecayTreeFitterAlg to access refitted candidates | Phys!970 (merged), Rec!2504 (merged) | comments | test again |
| Add functors FOURMOMENTUM, PX, PY, PZ and PE | Rec!2619 (merged) | comments | test |
| Fixed compilation warning due to not checking if an std::optional properly | Allen!713 (closed) | test | merge |
SOA proxy: only allow const access to remote data |
LHCb!3326 (closed) | test | merge |
| Enable MuonID by default following Rec!2599 (merged) | !1108 (merged) | changes needs to be done | test again |
| B2CC: Migration to ThOr functors | !1070 (merged) | work ongoing | test |
Merged MRs
| Description | MR(s) |
|---|---|
| Created a TOS test on Allen SelReports for single track Hlt1 lines | !1135 (merged) |
| Extend generated Config.cmake with upstream versions | |
| Modifications to allow conversion from ODIN v7 to v6 in Allen | LHCb!3302 (merged) |
| also exclude non thread safe GaudiHisto algs from hlt_pp_thor test | !1146 (merged) |
| Use Detector_DIR to set DETECTOR_PROJECT_ROOT | LHCb!3305 (merged) |
| Add special '+dd4hep' platforms to PlatformInfo list | LHCb!3311 (merged) |
| Fixed incorrect reference introduced in previous MR | LHCb!3312 (merged) |
| Fixed and uniformized use of Boost::unit_test_framework in LHCbKernel | LHCb!3313 (merged) |
| add FTTrackSelector | Rec!2602 (merged) |
| Converted ParticleToTrackContainer Class to Functional Framework | Alignment!219 (merged) |
| Adapt to consistent Track Enums and improve KalmanFilterTool | Brunel!1177 (merged), !1147 (merged), LHCb!3315 (merged), Allen!699 (merged), Alignment!218 (merged), Phys!1006 (merged), Rec!2601 (merged), LHCb!3299 (merged) |
| Adapted to changes in the Calo coming from the move to DD4hep | LHCb!3282 (merged), Lbcom!583 (merged), Rec!2584 (merged), Phys!999 (merged), Allen!684 (merged), !1054 (merged), Alignment!214 (merged) |
| Dropped MiniBrunel related tests and code | Brunel!1176 (merged) |
| Shrink the ITtrackExtrapolator interface | Rec!2609 (merged) |
| VPMonitors Patch | Lbcom!585 (merged) |
| Remove CommonParticles | Phys!1009 (merged) |
| Don't attempt to access the LHCbIDs of neutrals when TOS matching in HltEfficiencyChecker | MooreAnalysis!61 (merged) |
| Fix ThOr LifeTime bug | Rec!2566 (merged), !1065 (merged) |
| update_CaloHypoEff | Lbcom!580 (merged) |
| Use prefix ++ for counter | Allen!707 (merged), Rec!2617 (merged) |
| Fix ODIN v6 by converting from v6 to v7 when needed. | Allen!700 (merged) |
| Moved LineTraj to Detector for DD4hep + cleanup | LHCb!3294 (merged) |
| Adapted to new LHCb TaggedBool | Phys!1003 (merged) |
| Adapted to new LHCb TaggedBool | Rec!2594 (merged) |
| Modernize PrPlotFTHits and use DataHandles | Rec!2590 (merged) |
| Disable functor cache when building with dd4hep | !1028 (merged) |
| Implement gather2D proxy behaviour into SOACollections | LHCb!3320 (merged) |
| Fix issue in !3304 | LHCb!3316 (merged) |
| do not do any unsollicited duplicate removal and sorting of RawBank::Type during parsing of vector | LHCb!3314 (merged) |
| Fix bug in radiative lines | !1154 (merged), !1163 (merged) |
| Make MuonChi2MatchTool thread-safe | Rec!2599 (merged) |
| adjust CI configuration to build all sequences, rather than one sequence / job | Allen!696 (merged) |
| Update readme.md - fix how to obtain JSON file with configurable parameters | Allen!706 (merged) |
| Make DetDesc Condition objects accessible as YAML::Node | LHCb!3271 (merged) |
| Update complex sequence references | Allen!711 (merged) |
| Make hit efficiency and hit purity counters more accurate | Allen!710 (merged) |
| Allow of selection of particles in GetFlavourTaggingParticles | Phys!1010 (merged) |
Edited by Rosen Matev