Add test to compare Allen and Moore calo digits

The following discussion from !1270 (merged) should be addressed:

• @dovombru started a discussion: (+2 comments)

  Why are the digits decoded with the Moore algorithm (i.e. make_calo_reduced()) used as input here rather than the Allen calo digits?

assigned to @dovombru, @lmeyerga, and @cmarinbe

I'm seeing this now, what exactly do you have in mind for this test @dovombru , a comparison of number of digits and their energy and ADC values in Allen and Moore after decoding? !1270 (merged) was adding MC tests instead

Yes, that sounds reasonable. Unless you think that this is not needed and the MC test is enough? It seemed odd to me to use the Moore digits as input for the MC cluster test. But if the Allen clusters are verified against MC, maybe that is enough of a test?

yes it's a bit weird but I understand the reason is that the MC test uses Gaudi objects, so either you add a converter from Allen digits to Moore digits and use the latter, or create directly Moore digits (or write a new MC test using only Allen objects).

In any case, I think such a test would be useful, since it would test the decoding and Digits objects themselves, while the current test checks the clustering algorithm and we just checked the results are not much worse than in the Moore case but there's no 1-to-1 comparison for clusters while there should be for digits.

Obviously someone needs to write this test, any volunteers?

Yes, let's see if @rangel et al would agree to write the digit Moore-Allen comparison test?

That is clear a useful test. We are trying to finalize a two-cluster line and then we can work on that.

Note that @mstahl has prepared the corresponding test with a branch / commit in Allen and Moore:

Moore mstahl_calo_decoding_comparison#36a38f6e

Allen mstahl_calo_decoding_comparison#a1d81ae7

So it will only be a matter of creating the merge request running on samples with all currently supported raw bank versions.

I have created !2111 (merged) to include this test. The suggested changes to Allen are no longer necessary. I'm not sure who to ping for review. Maybe @cmarinbe?

added Calo label

added to epic &4

mentioned in issue Allen#128

mentioned in merge request !2111 (merged)

closed with merge request !2111 (merged)

mentioned in commit 5fda63c3