RTA Shift Summary 20/02/2023 - 06/03/2023

Personnel

RTA Maintainer: Rosen Matev (@rmatev)

RTA Shifter: Patrick Spradlin (@spradlin)

General

The comments of this issue were used by the RTA Shifter (@spradlin) to keep notes and help me to organize shifter activity related to MRs. They are an approximate shifter activity log.

New set of unpredictably failing tests

See #538 (closed).

The following tests in Moore occasionally fail due to mismatches with reference for 'PP2MCPRelations buffer size' counters:

• Hlt2Conf.test_hlt2_noUT_trackefflines
• Hlt2Conf.test_hlt2_trackefflines
• Hlt2Conf.test_persistreco_check_flavourtags

The impending merge of !2146 (merged) should suppress failures due to these mismatches. A permanent solution is in progress.

Allen merge pipelines

I have been seeing occasional failures to create and execute Allen merge pipelines. The failed pipelines are tagged with an 'error' label that has the hover text, 'The pipeline job activity limit was exceeded.' In at least one case, i was able to manually run the pipeline at a later time. In other cases, the pipeline was run properly on the subsequent push to the MR branch.

Open MRs

Shifter action required

In no particular order. In sets of MRs, the MR in bold is where the most recent test was run.

MRs	Title/Description	Shifter comments
LHCb!3947 (closed)	Add a new interface in TransportSvc to simulate the TransportSvc.intersections function under LHCb_v50 version	Active development; build failures in last ci-test
!2117 (merged)	hlt2 lines and new reco for PbPB	Active development; FATAL run-time errors in last ci-test
LHCb!3969 (merged) Rec!3310 (merged)	Introduce (and use) EndUT state	Active development; author asked to review and comment on [last ci-test])(Rec!3310 (comment 6491564))
LHCb!3935 (merged) Rec!3279 (merged) Analysis!946 (merged) DaVinci!815 (merged)	Add MCPrimaries and more MC functors	Authors pinged; expect update soon
Allen!1018 (closed)	no gec and veloSP lines for pit + change FT -> FTCluster name in passthrough lines	Status unknown; authors pinged
Allen!1083 (merged)	Generate lumi schema in Allen configuration	Tests good; assigned to reviewer
Allen!1079 (merged)	Add counters for random PV position to lumi summary	Further activity awaiting merge of Allen!1083 (merged)
Rec!3277 (merged) !2011 (merged)	Update JetAccessories to reconstruct MC jets	Active discussions on Rec!3277 (merged); merge conflicts in !2011 (merged)
Allen!1095 (merged)	Downstream/LongLivedParticle track reconstruction	Active development; build failures in recent tests
Allen!1111 (merged) !2034 (merged)	Tests to compare CPU and GPU decoding for Plume	Active development; Allen!1111 (merged) is marked Draft
Lbcom!652 (merged) !1703 (merged)	Fix CaloClusterEfficienncy/Use new MC samples in tests with data-like decoding versions	Follow-up with authors; probably ready for final testing; !1703 (merged) historically assigned to maintainer for some time
Detector!288 (merged) LHCb!3757 (merged) Rec!3107 (merged) !1758 (merged) MooreOnline!184 (closed)	Modernized Calo monitoring and dropped MoniAlg	Waiting general update of test samples to Run3; see author's comment on LHCb!3757 (comment 6467970)
!2122 (merged)	update according to BnoC 12Jan meeting	Active development; reviewer comments that need to be addressed; last test problematic
Allen!992 (merged)	Add multiplicity cuts for diphoton lines and include HLT1 Pi0 line	Follow-up; may need review; may be ready to assign to maintainer
LHCb!3872 (merged) Rec!3196 (merged) Allen!1072 (merged) !1909 (merged) Analysis!958 (merged) DaVinci!790 (merged) MooreOnline!190 (merged) MooreAnalysis!100 (merged)	Make name of algorithms independent of instantiation order	Active development
Allen!1129 (merged) !2129 (merged)	Update Allen-in-Gaudi configuration to fix tests for DD4Hep	Follow-up with author; may be ready for final testing and assignment to maintainer
!2132 (merged)	B&Q lines: Xib -> J/psi hhh and bbaryon -> Lc Ds h(h)	In review; comments to be resolved by authors
LHCb!2995 (merged) Lbcom!550 (merged) Boole!334 (merged) Rec!2403 (merged) Allen!865 (merged) Detector!181 (merged)	UT-newID-and-Geo	In review; probably need better titles
Rec!3274 (merged) !1873 (merged)	Sign functor, y-z straight-line intersection functors	Active development; may be ready for testing
Rec!3333 (merged) !2139 (merged)	Replace ProbeAndLongMatcher with MuonProbeToLongMatcher	Probably ready to be assigned to maintainer for merge; minor name change of an algorithm
LHCb!3907 (merged) Rec!3247 (merged) !1984 (merged) Analysis!942 (merged)	SOACollection particlev2	Active discussions

Assigned to maintainer

MRs	Title/Description	Shifter comments
Allen!1100 (merged)	Add option to include ODIN information in ntuple monitoring
!2031 (closed)	Add flags for alignment in reconstruction	Breaks a test in Alignment; maintainer delayed merging awaiting a MR that will fix the test
Rec!3322 (merged) DaVinci!853 (merged)	Added candidate multiplicity counter to ParticleCombiner
LHCb!3988 (merged) Lbcom!653 (merged) Rec!3329 (merged) MooreAnalysis!113 (merged) Alignment!354 (merged)	Remove LinkerTable and LinkerTool, augment LinkedTo, LinkedFrom
LHCb!3986 (merged) Analysis!956 (merged) DaVinci!841 (merged)	make pp2mcp relations unpacking consistent across different functions
!2054 (merged)	More fixes for Hlt2 lines	Requires approval
!2146 (merged)	pp2mcp buffer size counter	Work-around for #538 (closed)

added RTA RTA Shift Summary labels

assigned to @spradlin

LHCb!3952 (merged) !2052 (merged)

20/02/2023 - ci-test triggered at request of authors

• The previous test had failing tests in the LHCb project.

21/02/2023 - Checked results of test. Noted remaining failing tests to authors.

21/02/2023 - New ci-test triggered

• Author indicated that the failing test was obsolete,
  • It was removed in an update to LHCb!3952 (merged)
• Further discussion on LHCb!3952 (merged) indicates further cleanup of obsolete code.

21/02/2023 - Previous ci-test aborted and new one triggered.

• Author had to rebase to resolve a merge conflict that emerged after the test was triggered.

22/02/2023 - Author investigating some unexpected errors in ci-test

23/02/2023 - ci-test triggered at request of author.

24/02/2023 - Checked tests

• They look good to me.
• The new tests introduced in the MR pass on all platforms
• Some additional Moore tests fixed on DD4hep platforms (unsure if related)
• No new test failures.

24/02/2023 - Assigned to maintainer for merge

• As urgently requested by DPA

!2111 (merged)

20/02/2023 - ci-test triggered at request of authors

22/02/2023 - ci-test triggered at request of authors

27/02/2023 - Marked ready, ci-test triggered

• MR has been reviewed
• One more test before passing to maintainer

28/02/2023 - Checked tests, assigned to maintainer

• Tests consistent with previous round
• A test added by this MR fails on DD4hep builds
• A follow-up MR will be expected to fix it

Rec!3292 (merged) Analysis!952 (merged) !2094 (merged) DaVinci!836 (merged)

21/02/2023 - ci-test triggered at request of authors

• Merge conflicts in Rec!3292 (merged) prevented the test.

21/02/2023 - ci-test triggered after resolution of the conflicts that prevented the previous test.

21/02/2023 - Checked ci-test results. A small number of seemingly isolated test failures, all with I/O problems.

22/02/2023 - Assigned Rec!3292 (merged) and !2094 (merged) to maintainer for merge

• Author confirmed completion of work
• Approval in place for all of the MRs
• Did not assign Analysis!952 (merged) and DaVinci!836 (merged) to maintainer---these are DPA domain---asking maintainer about it.

22/02/2023 - Assigned to maintainer for merge

• Authors affirmed readiness
• Each MR in set approved by two non-authors

Rec!3318 (merged)

21/02/2023 - Noted recent activity. Authors triggered ci-test, which looks good. Assuming, for now, that the authors will let me know if they need me to do anything.

21/02/2023 - Discussed with maintainer. Assigned to be merged.

LHCb!3970 (merged)

21/02/2023 - Identified in previous shift as ready to be merged. Assigned to maintainer by previous shifter and awaiting merge. No required action from me anticipated.

LHCb!3947 (closed)
Follow
Status: Failed tests, comments to be addressed by authors

21/02/2023 - Identified in previous shift as needing follow-up on a ci-test triggered on 20/02/2023.

• New failures in LHCb tests on DD4hep platforms,
• Several comments and code recommendations that appeared after the ci-test that appear to be recommendations for fixes to the failed LHCb tests.

24/02/2023 - Pinged authors

27/02/2023 - Continue to follow

• Recent activity to address the comments.

28/02/2023 - ci-test triggered

28/02/2023 - Checked tests

• Build failures on DD4hep platforms

Allen!1119 (merged)

21/02/2023 - Rebased to master by author at request of reviewer/maintainer

• I manually triggered the full Allen pipeline (unsure if this was necessary).

!2081 (merged) !2090 (closed)

21/02/2023 - Identified in previous shift as needing follow-up on a ci-test triggered on 20/02/2023

• !2090 (closed) adds a test, which is failing in the ci-tests. Added comment indicating this.

21/02/2023 - Following discussions and activity on !2090 (closed)

• Updates to branch to address failure in previous ci-test
• New discussion thread.

24/02/2023 - Inquired about status.

LHCb!3972 (merged)

21/02/2023 - ci-test triggered at request of author

• Was reverted to Draft status in previous shift
• Was updated and un-WIP'ed by author 20/02/2023

Note Lbcom!651 (merged), which depends on LHCb!3972 (merged). If LHCb!3972 (merged) goes to merge immediately after the current round of testing, the follow-up Lbcom!651 (merged) separately. Otherwise, it may make sense to test them together going forward.

!1795 (closed)

21/02/2023 - Marked as 'ready' by authors

• Testing prevented by merge conflicts.
• It looks like the updates to master were merged into the branch rather than rebased. The commit history is messy.
• Need to consider what to recommend.

21/02/2023 - Discussed with maintainer. Made recommendation for cleaning the commit history.

The authors closed !1795 (closed) and opened !2117 (merged) (separate thread below).

LHCb!3894 (merged) Rec!3233 (merged) !2127 (merged)

21/02/2023 - Rec!3233 (merged) was assigned to be merged in the previous shift. Updated assignee for LHCb!3894 (merged) to the maintainer.

22/02/2023 - Rec!3233 (merged) changed to Draft status by author for further investigation.

23/02/2023 - ci-test triggered at request of author

• Rec!3233 (merged) Draft status was removed
• !2127 (merged) added to set.

24/02/2023 - Checked tests

• Maintainer noted that the clang builds failed
• Author looking into it.

24/02/2023 - ci-test triggered at request of author

24/02/2023 - ci-test aborted, new ci-test triggered, both at request of author

• Authors noticed an error in !2127 (merged) and corrected it.

25/02/2023 - Checked tests

• Look ok to me

!2117 (merged)
Replaces !1795 (closed)
Follow

21/02/2023 - The MR branch has updates to test references. Requested that these be reverted. Do not launch tests before the references changes are undone unless directed otherwise by the maintainer.

23/02/2023 - The authors may need git help to clean up the commit history.

23/02/2023 - Probably mark for squashing the commit history upon merge.

24/02/2023 - ci-test triggered at request of authors

• The commit history has been squashed to a single commit.

25/02/2023 - Checked tests

• Large decrease in sprucing throughput
• Multiple new failures of Hlt2 tests in Moore.

03/03/2023 - ci-test triggered

• Rerun tests to check current condition

04/03/2023 - Checked tests

• Still very bad
• New failures in Moore are mostly FATAL runtime errors
• Included authors ping in comments on test results

LHCb!3969 (merged) Rec!3310 (merged)
Follow

21/02/2023 - ci-test triggered at request of authors.

21/02/2023 - Author checked results of ci-test, noted several test failures, and is looking into them.

28/02/2023 - Checked MR

• Recent activity on Rec!3310 (merged)
• Continue to follow.

03/03/2023 - Pinged author

• Rec!3310 (merged) needs a formatting fix.

03/03/2023 - ci-test triggered

• Author fixed formatting and confirmed ready for testing.

04/03/2023 - Checked tests

• Build warnings on clang12
• Interesting failures in LHCb project IO tests.
• Author pinged in comments

Rec!3320 (merged)

21/02/2023 - ci-test triggered

• Comment indicates urgency to resolve user issues.
• Tagged maintainer in discussion asking about review. If this is urgent, it should not wait for me to figure out how to do things.

21/02/2023 - Maintainer checked the changes. If the tests are OK, assign to maintainer for merge.

21/02/2023 - Checked ci-test. Noted new failures of three DaVinciTutorials tests. Checking with developers if expected (may just indicate a need for a reference update).

22/02/23 - Authors replied that the changes were expected and evidence that the bug was fixed.

• Marked as needs ref update
• Assigned to maintainer for merge.

!2108 (closed)

21/02/2023 - Has merge conflicts.

• If no activity for a couple of days, prod authors.

22/02/2023 - MR closed by authors

Allen!806 (merged)

21/02/2023 - I may need to better understand what is going on. There are build warnings in Allen, and this MR is to address build problems in Allen.

24/02/2023 - Pinged Most recently active developers

• Currently unassigned---may want to assign to one of the developers.

24/02/2023 - Follow-up

• Authors indicated one more commit anticipated.

28/02/2023 - Checked MR, Allen pipeline triggered

• New commits have been pushed
• If no more activity by tomorrow, maybe test and escalate.

01/03/2023 - ci-test triggered

• Allen pipeline passed

01/03/2023 - Checked tests, assigned to maintainer

• Tests look good to me.

!2046 (merged)

21/02/2023 - Requires reference update; with maintainer

• In the previous shift, additional testing was indicated,
• Discussed with maintainer (prompted discussion on the MR)
  • The only changes since the previous successful test appear to be a rebase,
  • Maintainer will check in conjunction with updating the references.

LHCb!3935 (merged) Rec!3279 (merged) Analysis!946 (merged) DaVinci!815 (merged)
Follow

21/02/2023 - In previous shift, indicated as 'ci-test 16/02 on Rec!3279 (merged) --> weird errors in Moore --> under investigation by Maintainer'

01/03/2023 - Looked at status

• Now merge conflicts in Analysis!946 (merged)

02/03/2023 - Author pinged on LHCb!3935 (merged)

03/03/2023 - Author responded

• Expect ready for testing again this weekend.

Lbcom!644 (merged) Boole!439 (merged)

21/02/2023 - In previous shift report, commented as ci-test 15/02 --> expected errors, assigned to Maintainer to merge

• See branch updates since last test
• No current assignee
• Probably needs another round of testing and an assignee.

22/02/2023 - ci-test triggered

22/02/2023 - Assigned to maintainer

• Checked ci-test---observed same behavior of Boole tests noted in previous tests,
• Missed the fact that more recent testing has been taking place on Boole!439 (merged)---my bad,
• Description and discussion indicate that there is a pending MR in Gaudi that will correct the 'unhelpful log file entries' that show up in the Boole tests.

LHCb!3591 (merged) Rec!2917 (merged) Detector!319 (merged) Panoptes!236 (merged) DaVinci!843 (merged)

22/02/2023 - ci-test triggered at request of authors.

22/02/2023 - new ci-test triggered at request of authors

23/02/2023 - Author requests merge

• Checked test results
  • Looks good
  • Author identified a reference update---make sense to me
• One of the MRs in the set is still marked Draft
  • Asked author about it.

Asked maintainer whether a review is indicated.

23/02/2023 - Discussed with maintainer

• Merge of downstream MR in the set
• Full set merged by maintainer shortly thereafter.

Allen!1126 (merged)

22/02/2023 - Documentation update identified by project leader as ready for merge.

• Assigned to maintainer.

Allen!1018 (closed)
Follow

22/02/2023 - Some issues under investigation by author

• In previous shift report: 'ci-test 14/02 --> errors in the hlt1 persistency tests --> more investigations required'

01/03/2023 - Pinged author

Allen!1083 (merged)
Follow up

22/02/2023 - Some issues under investigation by authors

• In previous shift report: 'ci-test 15/02, some errors in MooreOnline, author pinged and is investigating'

02/03/2023 - Looked at MR

• Active discussions
  • Look like they are near a conclusion
  • Waiting on a check about unexpected behavior of testing system.

03/03/2023 - ci-test triggered at request of author

03/03/2023 - ci-test triggered at request of author

• Previous test manually aborted
• Author noticed DB-related errors and fixed them

04/03/2023 - Checked tests

• Probably ok
• Noted differences
• May be ready for merge

Allen!1079 (merged)
Waiting Allen!1083 (merged)

22/02/2023 - Waiting resolution and merge of Allen!1083 (merged)---see note in description.

Allen!1100 (merged)
Assigned to maintainer

22/02/23 - From the previous shift report: 'ci-test 17/02 --> tests looks reasonable --> moved to merge'

• Is assigned to maintainer

24/02/2023 - Allen full pipeline triggered

• Curiously, it had not been triggered.

24/02/2023 - Pinged author.

27/02/2023 - Checked

• Author responded to ping
• Still waiting for response to a discussion thread from third parties.
• May need to ping those third parties.

03/03/2023 - Pinged author

• Merge conflicts have emerged
• Test as soon as they are fixed.

03/03/2023 - ci-test triggered

• Allen full merge pipeline also triggered
• Author fixed merge conflicts

04/03/2023 - Checked tests

• Look ok to me

Allen!1096 (merged)

22/02/2023 - Branch has merge conflicts, probably requires are rebase.

• Author notified.

22/02/2023 - I need to understand better

23/02/2023 - Assigned to maintainer for merge

• I want to dicuss this case with the maintainer
• There are merge conflicts, but they are all due to out-of-date reference updates that were added by a previous shifter,
• There is a failing pipeline test for document compilation, but it may be related to the reference issues.

24/02/2023 - Following up

• Maintainer asked for a review of the physics content of the new lines
• Was approved in a WG meeting.
• Rebased, did not solve merge conflicts in the ref update.

27/02/2023 - ci-test triggered

• Previous test failed due to a merge error.

27/02/2023 - Checked tests

• Look good
• Waiting for final statistics

Rec!3277 (merged) !2011 (merged)
Follow

22/02/2023 - Ongoing discussions on Rec!3277 (merged)

• !2011 (merged) has merge conflicts.

02/03/2023 - Looked at MRs

• Recent activity on discussions on Rec!3277 (merged)
  • May be near testing again
• !2011 (merged) still has merge conflicts

!2026 (merged)

22/02/2023 - Need to understand the status of this MR

• 'Requires approval' flag still on
• Unresolved threads
• The previous shift report: 'ci-test 17/02 --> ready for merge, assigned Maintainer'

26/02/2023 - ci-test triggered on 25/02/2023 by maintainer

28/02/2023 - Checked tests

• Look good
• Needs a reference update---looks like ordering issue.

!2031 (closed)
Follow up, assigned to maintainer

22/02/2023 - ci-test triggered

• Author requests proceeding, discussions had stalled.

22/02/2023 - Checked test results

• A new failure of an Alignment test that might be relevant. Noted to author.

23/02/2023 - Waiting input from maintainer

• The MR will break a test (the noted test in Alignment)
• The breakage is understood, and there are plans to fix it
• Checking whether this is acceptable

02/03/2023 - Co-Assigned maintainer

• The open question is one for the maintainer
• Make assignment to put it on the maintainer's ToDo list

Lbcom!651 (merged)

22/02/2023 - ci-test triggered

• Its dependency LHCb!3972 (merged) was merged, this should go forward.

22/02/2023 - Assigned to maintainer

• Tests look good.

!2078 (merged)

22/02/2023 - In previous shift summary: 'ready for merge, Maintainer assigned'

• Verified that maintainer is the assignee.

LHCb!3963 (merged) Analysis!956 (merged) DaVinci!841 (merged)

22/02/2023 - ci-test triggered at request of authors

22/02/2023 - Assigned to author

• Some test results that cannot be fixed by reference updates
• Asked author to check.

23/02/2023 - ci-test triggered

• Author pushed update to Analysis!956 (merged) that should fix problem noted in the previous test.

23/02/2023 - Checked tests

• Two new failings tests, asked whether they are related to the MRs.

23/02/2023 - Note on tests

• The Allen seg faults in the LHCbIntegrationTests are, apparently, known and part of the discussion of LHCbIntegrationTests#4.
• They will probably show up as consistent failures in subsequent nightlies, rather than newly failing as in today's CI tests.

24/02/2023 - Assigned to maintainer for merge

!2106 (merged)

22/02/2023 - In previous shift summary: 'ci-test 18/02 OK, ready for merge, Maintainer assigned'

• Maintainer is an assignee

Rec!3319 (merged)

22/02/2023 - ci-test triggered

• Assigned to shifter (me) by author.

22/02/2023 - Assigned to author

• Test results indicate new compiler warnings.
• Noted and reassigned to author.

23/02/2023 - ci-test triggered

• Authors' comments indicate that it is 'fixed' by recent commits.

24/02/2023 - Checked tests

• They look OK.

24/02/2023 - Assigned to maintainer for merge

• Confirmation by author that it is ready.

Alignment!306 (merged)

22/02/2023 - ci-test triggered at request of author

• Updates documentation, no test changes expected.
• I triggered the test because there are changes to build files.

22/02/2023 - Assigned to maintainer

• No new failed tests.

Allen!1095 (merged)
Run tests

22/02/2023 - Checked status

• Open discussions awaiting reactions from authors.

24/02/2023 - Checked status

• New commits from authors
• Continue to follow.

03/03/2023 - Looked at MR

• New commits from author yesterday
• Allen pipeline throughput fails---throughput decreased
• Has merge conflicts
  • Looks like they are in test references
  • Can probably be resolved using the GitLab interface.

04/03/2023 - Resolved merge conflicts

• Used GitLab GUI
• Allen pipeline failed to start
  • Need to talk to maintainer about this
  • Also seen with other Allen MRs

05/03/2023 - Running merge pipeline

• Tried merge pipeline again after being contacted by author
  • Appears to be running
• Probably run ci-test after pipeline clears.

!2101 (merged)
Draft

22/02/2023 - Checked MR

• Failing format check
• Open discussions, but they seem to be in a good state
• I will assume, for now, that this is still in development. If no activity for a couple of days, ping authors.

27/02/2023 - Author pinged

• No activity since 17 Feb

01/03/2023 - Continue to follow

• Recent activity
• Merge conflicts

03/03/2023 - Marked Draft by author.

Allen!1111 (merged) !2034 (merged)
Draft

22/02/2023 - Checked MR

• Allen!1111 (merged) is marked as Draft
• Allen!1111 (merged) is in the review process
• !2034 (merged) is not Draft

Rec!3323 (merged) Analysis!959 (merged) DaVinci!847 (merged)

23/02/2023 - ci-test triggered at request of author

23/02/2023 - another ci-test triggered at request of author

24/02/2023 - platform-specific ci-test triggered at recommendation of DPA

• Interested to see if i formatted the command properly.
• Where do i find documentation for the ci-test command options?

24/02/2023 - Looked at code for Rec!3323 (merged)

• Changes a property name and modifes some verbose output.

24/02/2023 - Checked tests

• Look good.

Lbcom!652 (merged) !1703 (merged)
Follow

24/02/2023 - ci-test triggered at request of authors

27/02/2023 - ci-test triggered by authors

• Lbcom!652 (merged) appears to be a dependency
• Unclear if Lbcom!652 (merged) should be treated independently
  • It looks like a bug fix that could go in before !1703 (merged)

27/02/2023 - Looked at tests

• Much broken
• Still unclear about relationship between the two MRs in this presumed set.

02/03/2023 - Continue to follow

• Recent activity, including ci-tests triggered by author
• Comments indicate that it may soon be ready

Detector!288 (merged) LHCb!3757 (merged) Rec!3107 (merged) !1758 (merged) MooreOnline!184 (closed)
Follow

24/02/2023 - Pinged author, Looking at MRs

• In previous shift: 'ongoing development'
• Description recently updated to remove alread merged components.
• !1758 (merged) has merge conflicts
• Comments in the code added in Detector!288 (merged) includes a FIXME that is interesting.
• It looks to me like a substantial revision to the calorimeter monitoring histogramming.

24/02/2023 - Response from author

• The changes in this set of MRs is not backward-compatible
• Needs tests to be updated to sensible Run3 data---we do not have sensible Run3 data.

!2115 (merged)

24/02/2023 - ci-test triggered

25/02/2023 - Checked tests, assigned to maintainer

• Tests look ok to me
• I think this is a cleanup MR of some python.

!2114 (merged)

24/02/2023 - ci-test triggered

25/02/2023 - Checked tests, assigned to maintainer

• Tests look good.
• This MR updates test validators---no change in tests results after update.

Rec!3322 (merged) DaVinci!853 (merged)
Assigned to maintainer

24/02/2023 - ci-test triggered

• Simple addition of a counter, but affects the ParticleCombiner
• Probably want a review.

25/02/2023 - ci-test triggered

• Maintainer commented on choice of name for new counter
• Author updated
• Rerunning tests---maybe not necessary.

26/02/2023 - Checked tests

• Needs reference update
• Tests look good
• Noted 2 tests in DaVinci that look like they will need validator updates rather reference updates.

01/03/2023 - Continue to follow

• Author asked for advice about fixing a test

02/03/2023 - ci-test triggered at request of author

• New MR DaVinci!853 (merged) updates hard-coded validators

02/03/2023 - Checked tests, assigned to maintainer for merge

• Tests look ok
• The maintainer has already reviewed the changes and suggested an update, which was adopted

!2122 (merged)
Follow

24/02/2023 - ci-test triggered

• Changes to physics selections
• Will need review by WP3 coordinators, i think.

27/02/2023 - Checked tests

• Build errors
• Looks like missing python configuration or bad names
• Pinged author

28/02/2023 - ci-test triggered

28/02/2023 - ci-test manually aborted

• Build errors persist
• Identified by commenter

01/03/2023 - ci-test triggered at request of author

02/03/2023 - Checked tests

• Failed Moore.python test
  • Already identified by commenter
• New discussion threads opened.

Allen!1127 (merged) MooreOnline!204 (merged)

24/02/2023 - Author is triggering tests

• Looks like some cleanup and improvement of Online-trigger interface

28/02/2023 - Allen full pipeline triggered

• May be ready for testing.

28/02/2023 - ci-test triggered

• Allen full pipeline OK
• Last test 5 days ago
• Run test again before passing to maintainer

28/02/2023 - Assigned to maintainer for merge

• Tests look good.

!2120 (merged)

24/02/2023 - ci-test triggered

• Complicated relationship between this MR and !2081 (merged) and !2090 (closed)
• Contains the code of !2081 (merged), but not that of !2090 (closed)
• Author wants to sequence break:
  • Get this merged
  • Close !2081 (merged)
  • Merge !2090 (closed)
• Need to talk to maintainer

25/02/2023 - Checked tests

• The test added by the MR is failing with exceptions for all +detdesc platforms

27/02/2023 - ci-test triggered

• Author disabled some tests that fail on +detdesc due to the MR.

27/02/2023 - Checked tests

• Look good
• Will need ref updates.

Allen!992 (merged)
Follow up on status

25/02/2023 - ci-test triggered at request of author

27/02/2023 - Checked tests

• Tests look good
• Will need a ref update for one test.

03/03/2023 - Pinged author

• Asked about the merge pipeline failures