Re-add bremsstrahlung test
The (to-be) removed Hlt2Conf.test_hlt2_bremsstrahlung
test has to be added back in with modern/functional code.
see MR and comment: !2248 (comment 6675489)
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Maarten Van Veghel added RTA testing labels
- Maarten Van Veghel mentioned in merge request !2248 (merged)
mentioned in merge request !2248 (merged)
- Developer
Thanks @mveghel
Writing down what needs to be done more explicitly as I am reminding myself of what the test does (see https://gitlab.cern.ch/lhcb/Moore/-/blob/e9ffed531fd31dc73d49894dfacc5ad0f9b43cf3/Hlt/Hlt2Conf/tests/options/test_bremsstrahlung.py):
-
ParticleFilterWithPVs
usesFilterDesktop
and should be changed to the new equivalent class, ieParticleFilter
fromalgorithms_thor.py
-
anticipating the removal of
CombineParticles
, it should be changed toTwoBodyCombiner
can you confirm the above is correct in terms of LoKi -> Thor migration @pkoppenb @mvesteri @poluekt ?
-
- Albert Lopez Huertas mentioned in merge request !2373 (merged)
mentioned in merge request !2373 (merged)
- Carla Marin Benito assigned to @alopezhu
assigned to @alopezhu
- Author Developer
@alopezhu is this done, can this be closed?
Collapse replies - Developer
We were waiting for 2024 mc samples and a dd4hep configuration for them, I'll retake it this week. The test wasn't passing in dd4hep, just in detdesc.
Edited by Albert Lopez Huertas - Author Developer
okay! thanks
- Sebastien Ponce closed with merge request !2373 (merged)
closed with merge request !2373 (merged)
- Sebastien Ponce mentioned in commit c3e8752b
mentioned in commit c3e8752b