Skip to content
Snippets Groups Projects

B2OC: add a wrapper to check process argument

Merged Shunan Zhang requested to merge b2oc-shunan-utils into b2oc_upgrade
All threads resolved!
  • Add a python wrapper to check the process argument is either hlt2 or spruce.
  • Raise ConfigurationError instead of AssertionError.
  • Apply the wrapper to some line builders in bbaryon_to_cbaryon_hh

To-do:

  • Apply the wrapper to all line builder with assert inside. This should be done after !1035 (merged) is merged to avoid conflict.
  • Remove all @configurable in line builders

Related to #282 (closed).

cc @abertoli

Edited by Shunan Zhang

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @shunan this is very nice and indeed it would also be very nice to understand if we can get rid of @configurable everywhere

  • Shunan Zhang added 7 commits

    added 7 commits

    Compare with previous version

  • Shunan Zhang added 1 commit

    added 1 commit

    Compare with previous version

  • Shunan Zhang changed the description

    changed the description

  • Shunan Zhang added 1 commit

    added 1 commit

    • d36b7d6c - remove configurable wrapper for line builders

    Compare with previous version

  • Shunan Zhang marked the checklist item Remove all @configurable in line builders as completed

    marked the checklist item Remove all @configurable in line builders as completed

  • Shunan Zhang added 7 commits

    added 7 commits

    • 0c788a7f - assert cleanup in b_to_dh.py
    • ae59132f - assert cleanup in b_to_dhh.py
    • 89940882 - assert cleanup in b_to_dhhh.py
    • dcd7edef - assert cleanup in b_to_dmunu.py
    • ce5948cc - remove all_lines = {} in b_to_dh.py and b_to_dmunu.py, forgotten assert in b_to_dhh.py
    • 9bc94e70 - assert cleanup in b_to_cbaryon_hh.py
    • fce91f67 - import check_process from utils

    Compare with previous version

  • Shunan Zhang added 1 commit

    added 1 commit

    Compare with previous version

  • Shunan Zhang added 1 commit

    added 1 commit

    • 12688fa0 - assert cleanup in b_to_ddh.py

    Compare with previous version

  • Shunan Zhang marked the checklist item Apply the wrapper to all line builder with assert inside. This should be done after !1035 (merged) is merged to avoid conflict. as completed

    marked the checklist item Apply the wrapper to all line builder with assert inside. This should be done after !1035 (merged) is merged to avoid conflict. as completed

  • Shunan Zhang marked this merge request as ready

    marked this merge request as ready

  • Shunan Zhang resolved all threads

    resolved all threads

  • Shunan Zhang approved this merge request

    approved this merge request

  • Shunan Zhang mentioned in commit cb864829

    mentioned in commit cb864829

  • merged

  • Please register or sign in to reply
    Loading