Follow changes in Rec!2713

Rec!2713 (merged) added a distinction between SDOCA and DOCA -- the former just uses the 'first' state to compute DOCA, and the latter uses the IDistanceCalculatorTool interface (with LoKi::DistanceCalculator as default - and only - implementation) which only works on LHCb::Particle.

In case an algorithm uses more than one DOCA cut, this leads to warnings about duplicate properties -- but as these properties will always have the same key and value, they are harmless -- and could be fixed by instantiating tool handles without corresponding property, but that would require extending the grammar for DOCA to be able to specify the tool instance instead.

Must be applied in conjunction with Rec!2713 (merged), LHCb!3404 (merged)

added RTA label

mentioned in merge request Rec!2713 (merged)

• [2022-02-04 17:11] Validation started with lhcb-master-mr#3633
• [2022-02-04 17:24] Validation started with lhcb-master-mr#3633
• [2022-02-04 17:38] Validation started with lhcb-master-mr#3633
• [2022-02-05 12:21] Validation started with lhcb-master-mr#3643
• [2022-02-05 20:54] Validation started with lhcb-master-mr#3645
• [2022-02-06 13:50] Validation started with lhcb-master-mr#3646
• [2022-02-08 10:26] Validation started with lhcb-master-mr#3655

Hi @graven, how long lived is long lived? Would you agree on the statement, that for the most common use-cases two long tracks or particles decaying into long tracks can use DOCA, while other combinations involving downstream tracks should use LLDOCA?

added 1 commit

• 6be4e667 - Follow changes in Rec!2713 (merged): replace some DOCA with LLDOCA

Compare with previous version

added 1 commit

• fa01f789 - Follow changes in Rec!2713 (merged): replace some DOCA with LLDOCA

Compare with previous version

mentioned in issue #382 (closed)

To keep the result the same, a few lines which use 'long lived' particles (hence the LL in the name LLDOCA) are changed to use LLDOCA instead of DOCA. (Note: the Phi2KKMaker is also changed to keep the references the same, but it should probably just use DOCA)

If people are convinced that changing the default now, is the way to go. Then I think it is inconsistent to make this change, the references should be updated instead of overtraining on statistical fluctuations.

added 1 commit

• df3da9e8 - Follow changes in Rec!2713 (merged): replace some DOCA with LLDOCA

Compare with previous version

added 1 commit

• 1ae35cf5 - replace LLDOCA -> DOCA

Compare with previous version

changed title from Follow changes in Rec!2713 (merged): replace some DOCA with LLDOCA to Follow changes in Rec!2713 (merged)

changed the description

Note that currently, this also generates a lot of warnings:

B2OCB2DHHHCombiner#23               WARNING duplicated property name 'DistanceOfClosestApproach_DistanceCalculator', see https://its.cern.ch/jira/browse/GAUDI-1023
B2OCB2DHHHCombiner#23               WARNING duplicated property name 'DistanceOfClosestApproach_StandardGeometryTop', see https://its.cern.ch/jira/browse/GAUDI-1023
B2OCB2DHHHCombiner#23               WARNING duplicated property name 'DistanceOfClosestApproach_DistanceCalculator', see https://its.cern.ch/jira/browse/GAUDI-1023
B2OCB2DHHHCombiner#23               WARNING duplicated property name 'DistanceOfClosestApproach_StandardGeometryTop', see https://its.cern.ch/jira/browse/GAUDI-1023
B2OCB2DHHHCombiner#23               WARNING duplicated property name 'DistanceOfClosestApproach_DistanceCalculator', see https://its.cern.ch/jira/browse/GAUDI-1023
B2OCB2DHHHCombiner#23               WARNING duplicated property name 'DistanceOfClosestApproach_StandardGeometryTop', see https://its.cern.ch/jira/browse/GAUDI-1023
B2OCB2DHHHCombiner#23               WARNING duplicated property name 'DistanceOfClosestApproach_DistanceCalculator', see https://its.cern.ch/jira/browse/GAUDI-1023
B2OCB2DHHHCombiner#23               WARNING duplicated property name 'DistanceOfClosestApproach_StandardGeometryTop', see https://its.cern.ch/jira/browse/GAUDI-1023
B2OCB2DHHHCombiner#23               WARNING duplicated property name 'DistanceOfClosestApproach_DistanceCalculator', see https://its.cern.ch/jira/browse/GAUDI-1023
B2OCB2DHHHCombiner#23               WARNING duplicated property name 'DistanceOfClosestApproach_StandardGeometryTop', see https://its.cern.ch/jira/browse/GAUDI-1023
B2OCB2DHHHCombiner#22               WARNING duplicated property name 'DistanceOfClosestApproach_DistanceCalculator', see https://its.cern.ch/jira/browse/GAUDI-1023
B2OCB2DHHHCombiner#22               WARNING duplicated property name 'DistanceOfClosestApproach_StandardGeometryTop', see https://its.cern.ch/jira/browse/GAUDI-1023
B2OCB2DHHHCombiner#22               WARNING duplicated property name 'DistanceOfClosestApproach_DistanceCalculator', see https://its.cern.ch/jira/browse/GAUDI-1023
B2OCB2DHHHCombiner#22               WARNING duplicated property name 'DistanceOfClosestApproach_StandardGeometryTop', see https://its.cern.ch/jira/browse/GAUDI-1023

which are utterly harmless, but still way too annoying... So I've removed half them (the once which end in "_DistanceCalculator") -- but the other half of them require an annoying amount of work just to remove without any benefit other than getting rid of the warning, unless we add another constructor to ConditionAccessor...

@clemenci: it would be nice if there was a way to create a ConditionAccessor without generating a property, as in this case, the 'value' of the property is passed on construction, and should not be configurable afterwards -- i.e. I would like an 'escape clause' just as there is for ToolHandle...

I agree, it make sense to be able to turn off the implied property... actually it's probably better to avoid the property by default, unless we specify the name we want for the property.

mentioned in merge request LHCb!3404 (merged)

added 1 commit

• b8c67920 - use SDOCA instead of DOCA when functor is hosted by CombineTracks

Compare with previous version

• [2022-02-08 20:00] Validation started with lhcb-master-mr#3665
• [2022-02-09 11:21] Validation started with lhcb-master-mr#3668
• [2022-02-10 10:57] Validation started with lhcb-master-mr#3679

changed the description

added 1 commit

• 6203488a - remove now obsolete ignoring of warning

Compare with previous version