thor version of zee and zmumu HLT2 line

thor version of zee and zmumu HLT2 line

requested review from @rjhunter

assigned to @jideng

Hi @jideng, many thanks for doing this! Can you update to the latest qee_upgrade please? You just need an up-to-date qee_upgrade and to merge in the missing commits from there.

OK, I am doing it!

Thanks very much! That looks a lot better. There are however still a few changes that are unrelated to the line and are unnecessary. I guess it is because your stack is very old? Anyway, could you remove the changes to everything except the Z->ee and Z->MuMu lines please?

If you look in Changes at the top of this page, you'll see the other changes that I am referring to.

added 1 commit

• e84c4f85 - update: thor version for zee&zmumu HLT2 line

Compare with previous version

closed

reopened

added 3302 commits

• e84c4f85...a9035cb2 - 3301 commits from branch qee_upgrade
• 61766a37 - Merge branch 'qee_upgrade' into 'thor_zmumu_zee_run3'

Compare with previous version

added 2 commits

• 4fbfd5ce - update: thor fix copyright and python lint
• 48405c0a - Fixed formatting

Compare with previous version

added 1 commit

• 904ba55d - Delete run

Compare with previous version

added 1 commit

• b2b4d09d - Delete searchPath.cmake

Compare with previous version

added 1 commit

• ebea5edf - Delete searchPath.py

Compare with previous version

added 1 commit

• c8b24c47 - Delete toolchain.cmake

Compare with previous version

added 1 commit

• 680cc366 - Delete MooreDevDependencies.cmake

Compare with previous version

I delete 5 files(they do not appear in qee_upgrade branch or master branch),then I can pass the copyright check. but there is an error at build-docs. It looks like an enviorment problem?

Thanks @jideng. I'm seeing some other merge requests having a problem with build-docs, don't worry about that.

There are still some changes to git-lb-checkout, .gitignore, Makefile and build.conf that need to be removed. We should only see changes in the qee/ directory.

FYI I just updated the qee_upgrade branch. There's quite a lot there, could you add the extra commits from there again please?

I'll also review the rest of this MR while I'm here now.

It is painful to find every changes and modify them. I also try to rebase this branch to qee_upgrade but meet some errors. Then, I build a new branch to merge.

this is the new branch !1374 (merged)

@rjhunter

added qee label

Could you test the rate and efficiency of the lines with HltEfficiencyChecker please? They should be completely unchanged by the migration to ThOr functors, but if there is any difference it would be really important to find it. Can you please run HltEfficiencyChecker once from qee_upgrade with the LoKi-based version of the lines, and once again on this branch, and then post the results of both here. There should be some options files available in Moore/Hlt/Hlt2Conf/options/qee, which I think were written by you :)