Follow up of moving functions out of hlt1_tracking

Follow up of !1443 (merged).

When calling the deprecated functions an exception is thrown. The reason for throwing exceptions over removing the functions is to be able to give users an error message with instructions what to do.

added RTA label

added 1 commit

• eea839e9 - Fixed formatting

Compare with previous version

added 1 commit

• a9cdf09b - bugfix

Compare with previous version

Deprecated normally means the function is still there and can be used but is discouraged pending removal. In this case the functions have moved and users need to adjust immediately. So I'm not sure I see the benefit of this approach compared to removing the code and updating the documentation to reflect what users should be doing. If we stick to this approach could you in parallel open an issue so we remember to eventually remove this code for good?

Also, although I didn't comment on the original MR, in general I would prefer it if we could avoid these kinds of configuration reorganisations over the next months, so we can focus on changing those things which absolutely do have to change to enable datataking and commissioning.

Also, although I didn't comment on the original MR, in general I would prefer it if we could avoid these kinds of configuration reorganisations over the next months, so we can focus on changing those things which absolutely do have to change to enable datataking and commissioning.

I think the changes in this merge request remove potential confusion, also during the commissioning, in our codebase, especially because it has happened that people were confused by what these functions do. That being said, I don't mind if people decide that merge requests are not necessary and are closed as they don't bring substantial benefit.

mentioned in issue #421 (closed)

mentioned in issue #426 (closed)

mentioned in issue #432 (closed)

Is this ready to be tested ?

added 301 commits

• a9cdf09b...176a2943 - 296 commits from branch master
• 12309bf3 - resolve conflicts
• d39fe227 - solve conflicts
• 5770c306 - solve conflicts
• 040df7ec - Fixed formatting
• e6daca5a - bugfix

Compare with previous version

added 1 commit

• 9d72d095 - fix linting

Compare with previous version

added 1 commit

• c9c48c9f - Fixed formatting

Compare with previous version

assigned to @fsouzade

added ci-test-triggered label

• [2022-06-08 16:48] Validation started with lhcb-master-mr#4678

assigned to @sponce and @rmatev

resolved all threads

approved this merge request

merged

mentioned in commit b8b4144d

mentioned in issue #444 (closed)

mentioned in issue #404 (closed)