Skip to content
Snippets Groups Projects

Add an option file to run Sprucing throughput test

Merged Shunan Zhang requested to merge spruce-throughput-test into master
All threads resolved!

Add an option file spruce_all_lines.py to run Sprucing throughput test.

The test is configured by a analytic run and categorize all Sprucing lines into one single stream.

A local test was run, and the flame graphs are attached below. The throughput for Sprucing on my local machine is found to be 492 Hz.

link to DPA WP1 task lhcb-dpa/project#25 and lhcb-dpa/project#90.

Needed by lhcb-datapkg/PRConfig!236 (merged).

cc @erodrigu @nskidmor @abertoli

FlameBars.pdf

flamy.svg

Edited by Shunan Zhang

Merge request reports

Merge request pipeline #4160379 passed with warnings

Merge request pipeline passed with warnings for 8d32f159

Approval is optional

Merged by Sebastien PonceSebastien Ponce 2 years ago (Jul 19, 2022 8:57am UTC)

Merge details

  • Changes merged into with a2883a92.
  • Deleted the source branch.

Pipeline #4250384 passed with warnings

Pipeline passed with warnings for a2883a92 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Great to see this extra validation being put in place :thumbsup:!

  • Shunan Zhang added 26 commits

    added 26 commits

    Compare with previous version

  • Shunan Zhang resolved all threads

    resolved all threads

  • Shunan Zhang added 8 commits

    added 8 commits

    • b1e74b92...27e892b3 - 4 commits from branch master
    • 847ad211 - add spruce_all_lines to the MooreCache CMakeLists for the throughput test
    • b2cd9df4 - bug fix in the test option
    • c024b756 - Merge branch 'master' into spruce-throughput-test
    • fd96a29c - do not use make_fastest_reconstruction for Sprucing

    Compare with previous version

    • Author Developer
      Resolved by Shunan Zhang

      @rmatev @chasse There's a warning when I used make_fastest_reconstruction:

      /data4/lhcb/zhangsn/Upgrade/stack/LHCb/InstallArea/x86_64_v2-centos7-gcc11-opt/python/PyConf/tonic.py:436: UserWarning: Bound function <reconstruction() at hlt2_global_reco.py:197> was not called within a bind. Stack trace:
        File "/data4/lhcb/zhangsn/Upgrade/stack/Moore/Hlt/Hlt2Conf/options/sprucing/spruce_all_lines.py", line 147, in <module>
              config = run_moore(options, make_streams, public_tools, analytics=True)

      so I just removed this bind in the test option.

      However after I required functor cache for this test by adding force_functor_cache upfront, the throughput test failed. The log file is attached below. I simply put the name of this option into MooreCache/CMakeLists.txt and re-compiled the stack. Did I miss anything?

      The log file is too large to attach so I removed O(10000) lines in the middle. I believe most of them are useless, and seems the critical message is:

      HLTControlFlowMgr                     FATAL Event failed in Node VoidFilter/Streaming_filter
      HLTControlFlowMgr                     FATAL *** Event 25 on slot 25 failed! ***

      ThroughputTest.x86_64_v2-centos7-gcc11-opt.128t.1j.100e.0.log.require_cache.crash

  • Shunan Zhang added 1 commit

    added 1 commit

    Compare with previous version

  • Shunan Zhang added 1 commit

    added 1 commit

    • 8d32f159 - don't compile functor library for spruce_all_lines by default

    Compare with previous version

  • Shunan Zhang marked this merge request as ready

    marked this merge request as ready

  • Shunan Zhang resolved all threads

    resolved all threads

  • Author Developer

    @rmatev this MR is also ready, and it needs to be tested and merged with lhcb-datapkg/PRConfig!236 (merged). Could you also take care of this? Thanks.

  • assigned to @rmatev

  • unassigned @shunan

  • assigned to @sponce

  • Sebastien Ponce resolved all threads

    resolved all threads

  • Sebastien Ponce approved this merge request

    approved this merge request

  • Sebastien Ponce mentioned in commit a2883a92

    mentioned in commit a2883a92

  • Eduardo Rodrigues resolved all threads

    resolved all threads

  • mentioned in issue #456 (closed)

  • mentioned in issue #456 (closed)

  • Please register or sign in to reply
    Loading