Skip to content
Snippets Groups Projects

make packing configuration simpler

Merged Sevda Esen requested to merge sevda-simpler-packing into master

Simplify packing/unpacking configuration. Remove all references to PersistRecoConf.

To be tested with LHCb!3750 (merged) DaVinci!747 (merged) MooreAnalysis!92 (merged) Analysis!918 (merged)

Edited by Sevda Esen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Christoph Hasse
  • Sevda Esen added 2 commits

    added 2 commits

    Compare with previous version

  • Sevda Esen added 1 commit

    added 1 commit

    Compare with previous version

  • Sevda Esen added 1 commit

    added 1 commit

    Compare with previous version

  • Sevda Esen added 1 commit

    added 1 commit

    Compare with previous version

  • Please fix the pipeline. Both formatting and python lint are failing

  • Sevda Esen marked this merge request as draft

    marked this merge request as draft

  • Morning Sevda, would it not make sense to move all persistency stuff once and for all to a "framework dependency" such as LHCb where anyway we already have related stuff (for example see https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/GaudiConf/python/GaudiConf/PersistRecoConf.py and others)? Having related stuff in one library seems better to me in just about any perspective I take. Happy to hear your thoughts, thanks.

    • Author Contributor
      Resolved by Sevda Esen

      Hi @erodrigu PersistRecoConf was meant to be used only for standard reco locations but I expanded its usage to all packing/unpacking so it became cumbersome to maintain. With @graven upcoming MR, most of it will not even be needed anymore.

      With this MR I first would like to separate packing and unpacking. Packing is only done in Moore, packers are only called inside persistency code. There will be a similar MR for unpacking where for all unpacking related code will stay in LHCb to be used by both Moore and DaVinci.

  • Sevda Esen added 1 commit

    added 1 commit

    • 6f8b8907 - move manifest json file to persistency

    Compare with previous version

  • Sevda Esen added 2 commits

    added 2 commits

    Compare with previous version

  • Sevda Esen added 1 commit

    added 1 commit

    • fb718b5e - fix duplicates in packed locations

    Compare with previous version

  • Sevda Esen added 1 commit

    added 1 commit

    Compare with previous version

  • Sevda Esen added 75 commits

    added 75 commits

    Compare with previous version

  • Sevda Esen added 1 commit

    added 1 commit

    • ca21dc18 - make relation packer to take multiple locations

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading