Skip to content
Snippets Groups Projects

refactor(testing) remove a few old exclusions that were quite costly

Merged Christoph Hasse requested to merge chasse_cleanup_exclusions into master
All threads resolved!

@clemenci @sponce this diff removes/refactors the regex exclusions that were very expensive on long strings.
I've now run all Moore tests with a timing around the ValidateOutput function in Gaudi's BaseTest.py and have only found 2 tests that take 20s and 30s for their validation.
Those are the two hlt2_protoparticles_{baseline,fastest} tests.
Funny enough they don't have very long lines, but a metric shit ton of short lines so I can't really do much about that :sweat_smile:

Edited by Christoph Hasse

Merge request reports

Merge request pipeline #4235994 passed with warnings

Merge request pipeline passed with warnings for 138fb0eb

Approved by

Merged by Sebastien PonceSebastien Ponce 2 years ago (Jul 15, 2022 7:56pm UTC)

Merge details

  • Changes merged into master with 3b3b0091.
  • Deleted the source branch.

Pipeline #4237083 passed with warnings

Pipeline passed with warnings for 3b3b0091 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading