Drop "Line" suffix in line names

Resolves Rec#375 (closed) and #134 (closed) .

The suffix "Line" is omitted from every line, and the name pattern is changed accordingly. This means that line names ending in "Line" will raise an error, while a line like "Hlt2_track_as_straight_line" should be fine.

• b8e05726 Rename individual lines in the line definitions and documentation (Hlt2 lines)
• a44a8b4e Adapt line name parsing
• 77a2b159 Adapt qmtests to new naming convention
• acf1d542 Rename (CPU) Hlt1 lines and lines in standalone options; adapt tests

assigned to @mstahl

added RTA label

added 5 commits

• e3757c2b - Merge branch 'enable-functor-cache-dd4hep' into 'master'
• 37349aac - [line naming] remove Line from line names
• 4019448e - remove deprecated line
• 1ee976ac - [line naming] adapt line name parsing
• b83f3540 - [line naming] adapt tests to new line name convention

Compare with previous version

added 5 commits

• c4bf24fa - 1 commit from branch master
• b8e05726 - [line naming] remove Line from line names
• d076668b - remove deprecated line
• e24f8b61 - [line naming] adapt line name parsing
• 055798b6 - [line naming] adapt tests to new line name convention

Compare with previous version

added 1 commit

• c10e03c4 - [line naming] adapt tests to new line name convention

Compare with previous version

changed the description

marked this merge request as ready

I didn't check how bad the change is for projects downstream of Moore. @cagapopo can we do this in a ci-test if there are enough resources available? One platform should be sufficient for now.

marked this merge request as draft

mentioned in issue Rec#375 (closed)

added ci-test-triggered label

• [2022-08-17 09:43] Validation started with lhcb-master-mr#5433

Morning @mstahl, I did not check (apologies for being lazy but 129 changed files is a lot) but did you also modify the regex checkers I commented on at Rec#375 (comment 5864173) so that all types of selection lines now do not have Line or _Line in their names? Seems we should either be random (terrible) or fully consistent across the board. Advance thanks.

FYI @nskidmor.

Hi @mstahl, with the changes introduced in this MR possibly would be good to directly ping all RTA liaisons / MiCos / ... before merging so they are not so confused when this will be pushed?

Thanks for doing this @mstahl, it will also close #134 (closed). There was too much inertia/Rosen and I had too many other things to do to do this at that time.

Thanks also for going through the HltEfficiencyChecker documentation. I'm a bit worried that this will cause HltEfficiencyChecker problems downstream in MooreAnalysis and that the tests might not necessarily catch it, let's see what the CI-test digs up.

added 2 commits

• e4ac39fe - [line naming] adapt tests to new line name convention
• 3cb1b7e3 - [line naming] rename Hlt1 lines and adapt more tests

Compare with previous version

added 1 commit

• 6165b1a8 - [line naming] rename Hlt1 lines and adapt more tests

Compare with previous version

added 3 commits

• a44a8b4e - [line naming] adapt line name parsing
• 77a2b159 - [line naming] adapt tests to new line name convention
• acf1d542 - [line naming] rename Hlt1 lines and adapt more tests

Compare with previous version

changed the description

• [2022-08-18 09:32] Validation started with lhcb-master-mr#5442
• [2022-08-23 10:24] Validation started with lhcb-master-mr#5475

added 19 commits

• acf1d542...4a9aec5a - 15 commits from branch master
• 43de1078 - [line naming] remove Line from line names
• e9653be6 - [line naming] adapt line name parsing
• 1276588e - [line naming] adapt tests to new line name convention
• 133e07c4 - [line naming] rename Hlt1 lines and adapt more tests

Compare with previous version

mentioned in issue #467 (closed)

Good morning @gunther! This should be ready to go once the references are updated. (There's an unresolved discussion concerning 1 failing test due to missing AllenTESProducer counters, but I saw that these counters are also there in master, so it should be fine with a ref update).

assigned to @gunther and unassigned @mstahl

marked this merge request as ready

changed title from Remove "Line" in line names to Drop "Line" suffix in line names

changed the description

mentioned in merge request !1395 (merged)

/ci-test

mentioned in merge request !1289 (merged)

mentioned in commit a1c04b97

mentioned in issue #469 (closed)

added needs ref update label

mentioned in merge request !1077 (merged)

mentioned in merge request !1605 (merged)

mentioned in issue #474 (closed)

assigned to @mstahl and unassigned @gunther

mentioned in merge request !1755 (merged)

mentioned in merge request !1753 (merged)

added 127 commits

• 133e07c4...75d2f51b - 123 commits from branch master
• 6de233df - [line naming] remove Line from line names
• 4194dc10 - [line naming] adapt line name parsing
• bd80d196 - xsx[line naming] adapt tests to new line name convention
• e78b4361 - [line naming] rename Hlt1 lines and adapt more tests

Compare with previous version

assigned to @msaur

/ci-test

• [2022-09-14 18:31] Validation started with lhcb-master-mr#5654
• [2022-09-19 11:11] Validation started with lhcb-master-mr#5680

added 2 commits

• 593cd2a2 - [line naming] adapt tests to new line name convention
• 5768efff - [line naming] rename Hlt1 lines and adapt more tests

Compare with previous version

/ci-test

assigned to @rmatev and unassigned @mstahl and @msaur

added cleanup label