Skip to content
Snippets Groups Projects

WIP: Add MC checking sequence

Closed Sascha Stahl requested to merge sstahl-add-mc into master

Adds MC checking sequence as implemented before in https://gitlab.cern.ch/lhcb/Brunel/blob/master/Rec/Brunel/python/upgrade_options/HLT1BaseLine.py#L222

More description to be added later.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • how far is this @sstahl? can we merge? i would like to get the merges going, otherwise the rebase mess is going to be unbearable when more MRs pop up

  • Author Maintainer

    It works, but probably can be made a bit nicer.

  • Rosen Matev resolved all discussions

    resolved all discussions

  • Rosen Matev
  • Rosen Matev
    • Resolved by Sascha Stahl

      shall we test this by running the new options file and checking for no warnings/errors/fatals?

      btw, it's a bit strange that the options in Hlt1Conf import RecoConf which imports Hlt1Conf itself, but you probably realized this. We have to move things out of Hlt12Conf

  • assigned to @rmatev

  • Sascha Stahl added 1 commit

    added 1 commit

    • caa4948b - Add copyright and move file to RecoConf

    Compare with previous version

  • Sascha Stahl resolved all discussions

    resolved all discussions

  • Rosen Matev added 41 commits

    added 41 commits

    Compare with previous version

  • rebased on master

  • Rosen Matev added 4 commits

    added 4 commits

    Compare with previous version

  • @nnolte @apearce I removed the dependency on gaudi/Gaudi!929 (merged) and added one on Rec!1584 (merged) (which we anyway had, but this time it can be merged). I also fixed the new magic modules for pytest and a silly issue in HLT1. I'm not quite sure how you ran them before :wink:

    What's left is just to exercise the new code

    Edited by Rosen Matev
  • Rosen Matev added 1 commit

    added 1 commit

    • 91f04d98 - Add qmtest for mc checking sequence

    Compare with previous version

  • Rosen Matev added 6 commits

    added 6 commits

    Compare with previous version

  • rebased on top of !189 (merged) . Probably needs to wait for a fix in Rec/master

    Edited by Rosen Matev
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading