Skip to content
Snippets Groups Projects

Algorithm/tool caching and removal of hashes in names

Merged Niklas Stefan Nolte requested to merge NN_algorithm_store into master
  • introduced class stores for tools/algorithms to have earlier deduplication
  • same conf, different names -> failure
  • fixed some bugs
  • more checks, you cannot give plain Configurables as inputs to an Algorithm/Tool constructor
  • formatting
  • added unique names without hashes

closes #30 (closed)
closes #12 (closed)
closes #31 (closed)
closes #26 (closed)

Edited by Rosen Matev

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alex Pearce resolved all discussions

    resolved all discussions

  • Alex Pearce
  • added 1 commit

    Compare with previous version

  • Niklas Stefan Nolte resolved all discussions

    resolved all discussions

  • added 1 commit

    Compare with previous version

  • Niklas Stefan Nolte changed the description

    changed the description

  • Author Contributor

    i think after this MR we can start moving to LHCb, do you agree?

  • Niklas Stefan Nolte changed title from WIP algorithm/tool caching to WIP algorithm/tool caching, removal of hashes in names and fail in case of different names for same configuration

    changed title from WIP algorithm/tool caching to WIP algorithm/tool caching, removal of hashes in names and fail in case of different names for same configuration

  • Pretty much. I would like to sweep through PyConf for formatting, to make sure the names are all good, and to add any missing docs. Do you want any other issues addressed before moving @nnolte @rmatev?

  • assigned to @rmatev

  • Niklas Stefan Nolte resolved all discussions

    resolved all discussions

    • Resolved by Niklas Stefan Nolte

      the test_hlt2_example test fails for me on this branch

      Traceback (most recent call last):
        File "<string>", line 25, in <module>
        File "/home/rmatev/distcc/stack/LHCb/InstallArea/x86_64-centos7-gcc8-opt/python/LoKiCore/decorators.py", line 3020, in hybrid_context_deco
          format(symbol_name, ' or '.join(context_types)))
      AssertionError: Functor AALLSAMEBPV requires context (type dvalgo) but none is defined.
  • added 1 commit

    Compare with previous version

  • Niklas Stefan Nolte resolved all discussions

    resolved all discussions

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading