MR for upsilon -> ll lines

Essentially a copy of

!1375 (closed)

This is now hopefully done with everything properly rebased. If this is okay, I am happy to close the MR 1375.

Edit : The rate from a test I ran a short while ago after the second round of fixes following comments from @tfulghes and @tmombach :

LAZY_AND: Hlt2RD_Upsilon2ToUpsilon1PiPi_Upsilon1ToEE                                         #=14983   Sum=0           Eff=|( 0.000000 +- 0.00000 )%|
LAZY_AND: Hlt2RD_Upsilon2ToUpsilon1PiPi_Upsilon1ToMuMu                                       #=14983   Sum=0           Eff=|( 0.000000 +- 0.00000 )%|
LAZY_AND: Hlt2RD_Upsilon2ToUpsilon1PiPi_Upsilon1ToTauTau                                     #=14983   Sum=2           Eff=|(0.01334846 +- 0.00943816)%|
LAZY_AND: Hlt2RD_UpsilonToMuE                                                                #=14983   Sum=0           Eff=|( 0.000000 +- 0.00000 )%|
LAZY_AND: Hlt2RD_UpsilonToMuMu                                                               #=14983   Sum=1           Eff=|(0.006674231 +- 0.00667401)%|
LAZY_AND: Hlt2RD_UpsilonToTauE                                                               #=14983   Sum=2           Eff=|(0.01334846 +- 0.00943816)%|
LAZY_AND: Hlt2RD_UpsilonToTauMu                                                              #=14983   Sum=1           Eff=|(0.006674231 +- 0.00667401)%|
LAZY_AND: Hlt2RD_UpsilonToTauTau                                                             #=14983   Sum=1           Eff=|(0.006674231 +- 0.00667401)%|

added RTA label

marked this merge request as draft

changed title from Draft : MR for upsilon -> ll lines to Draft: MR for upsilon -> ll lines

requested review from @hvc

requested review from @jadevrie

requested review from @cagapopo

requested review from @tfulghes

assigned to @nraja

@nraja could you please

• rebase on top of the latest master branch and test to make sure it's up to date
• fix the formatting (if you click on the CI test it will tell you how to)
• put the rate as obtained from the minbias sample into the header and all the lines that you are writing to make sure it is obviously clear what lines you include and how large the impact on the overall bandwidth/rate is
• and then you can notify the reviewers that I listed primarily (maybe you can include the RD conveners as well, not only the VRD ones) so that at least one can go and check through your selection?
• I suggest to close and remove the stale MR as well

assigned to @fwilson

added 368 commits

• 89a3ea2f...1f767a8c - 364 commits from branch master
• 4a70545a - First version after all the rebasing and all that - refer to MR 1375
• b1eb62ed - Update with black formatting
• 341d20b7 - Remove unused variables
• 116974e5 - Fixed formatting

Compare with previous version

Hi @tmombach and reviewers,

Thanks for this.

• Rebase is done.
• The stale MR is closed.
• Formatting - I am not sure what is the problem here, I see only the docs build has failed. All other checks seem to have passed.
• Rate - I will do so asap.

Cheers, Raja.

changed the description

added 78 commits

• 116974e5...f653ea2d - 73 commits from branch master
• d68a4e07 - First version after all the rebasing and all that - refer to MR 1375
• 928cbeab - Update with black formatting
• 36d76486 - Remove unused variables
• 27852a54 - Fixed formatting
• 401b2c72 - Rebased again

Compare with previous version

added 2 commits

• 01deec91 - Add hashing to names for uniqueness
• 13402fcf - Bug fix : remove name from make_rd_prompt_electrons as that caused conflict,...

Compare with previous version

@tfulghes and everyone else involved - I believe I am done with the changes and am happy for you to review and give me suggestions for this, going forward.

added RD label