Skip to content
Snippets Groups Projects

Fix graphing of tool inputs

Merged Alex Pearce requested to merge apearce-graph-flow-fixups into master
All threads resolved!

Graphing of tool inputs to algorithms was broken by !225 (merged) and this was causing the nightlies to fail. After fixing that I noticied some other funky features so fixed those to.

This is the current HLT2 reconstruction data flow after the changes:

HLT2 reconstruction data flow

Edited by Alex Pearce

Merge request reports

Pipeline #1066473 passed

Pipeline passed for 47996ac9 on apearce-graph-flow-fixups

Approved by

Merged by Rosen MatevRosen Matev 5 years ago (Aug 29, 2019 3:45pm UTC)

Merge details

  • Changes merged into master with 46a78d4a.
  • Deleted the source branch.

Pipeline #1066535 passed

Pipeline passed for 46a78d4a on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alex Pearce added 3 commits

    added 3 commits

    • 7b61bfc3 - Fix graphing of tool inputs.
    • 65808f53 - Treat public/private Tool status explicitly.
    • 924e692f - Factor out colour names.

    Compare with previous version

  • Niklas Stefan Nolte
  • Alex Pearce changed the description

    changed the description

  • Alex Pearce added 3 commits

    added 3 commits

    • 6e0a067b - Treat public/private Tool status explicitly.
    • f314d499 - Factor out colour names.
    • b4ad898b - Declare public tool as such.

    Compare with previous version

  • Alex Pearce added 1 commit

    added 1 commit

    • 47996ac9 - Declare public tool as such.

    Compare with previous version

  • Rosen Matev resolved all threads

    resolved all threads

  • All tests pass for me as well, so let's profit right away!

  • Rosen Matev approved this merge request

    approved this merge request

  • merged

  • Rosen Matev mentioned in commit 46a78d4a

    mentioned in commit 46a78d4a

  • Rosen Matev changed milestone to %v50r0

    changed milestone to %v50r0

  • Please register or sign in to reply
    Loading