Skip to content
Snippets Groups Projects

split track containers and persistency (versioning)

Merged Maarten Van Veghel requested to merge mveghel-calov1persistencyfix into master

Introduces split-per-track-type persistency. Track, PID objects and ProtoParticles are all in split containers. Main reason to have more control over persistency.

Also fixes upstream proto/track persistency.

Tested with Hlt/Hlt2Conf/options/hlt2_2or3bodytopo_realtime.py and subsequent sprucing unpack step.

One of the things it does it cleans up and removes the use of merged containers that copy tracks/muonpid/richpid objects, but uses SharedObjectsContainer such that pointers to the individual per-track-type objects are used for merged containers.

Currently the tracks are copied to their persisted location, but this should be SharedObjectsContainers which should be persisted, this way the actual underlying object persistency is handled anonymously (needs !2281 (merged) and SharedObjectsContainers to be persisted)

It aims to fix #392 (closed). @sesen @graven @decianm

Also Ttrack reco should be cleaned up @isanders Maybe fixed in other MRs, see also #588

Also adds fixes for calohypo persistency in charged protoparticles (it started with this, this branch and got out of hand, as it needs these fixes to work).

In addition, uses work of @sbelin from Rec!3509 (closed), !2141 (closed) and DaVinci!897 (closed) (merged into the relevant branches)

Goes with LHCb!4127 (merged), Rec!3423 (merged), Alignment!394 (merged), DaVinci!926 (merged), MooreAnalysis!126 (merged), MooreOnline!268 (merged), lhcb-datapkg/PRConfig!327 (merged)

needs LHCb!4191 (merged) (cherry picked and committed to LHCb!4127 (merged))

Edited by Maarten Van Veghel

Merge request reports

Merge request pipeline #5963516 passed with warnings

Merge request pipeline passed with warnings for 7183b507

Merged by Christopher Rob JonesChristopher Rob Jones 1 year ago (Jul 27, 2023 6:41pm UTC)

Loading

Pipeline #5964626 passed with warnings

Pipeline passed with warnings for 0c2387cd on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Eduardo Rodrigues
  • Maarten Van Veghel changed title from Draft: upstream proto persistency fixes to Draft: split track containers and upstream/ttrack proto persistency fixes

    changed title from Draft: upstream proto persistency fixes to Draft: split track containers and upstream/ttrack proto persistency fixes

  • Maarten Van Veghel changed the description

    changed the description

  • Maarten Van Veghel changed the description

    changed the description

  • Maarten Van Veghel changed title from Draft: split track containers and upstream/ttrack proto persistency fixes to Draft: split track containers and upstream proto persistency fixes

    changed title from Draft: split track containers and upstream/ttrack proto persistency fixes to Draft: split track containers and upstream proto persistency fixes

  • added 1 commit

    • eabcb1e3 - reco config with split track containers

    Compare with previous version

  • added 1 commit

    • 405c3125 - also produce empty persistable locs

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • e7e25fc1 - versioning of persistence locations

    Compare with previous version

  • I created this: LHCb#312 (closed) to keep track of the location versioning.

  • Maarten Van Veghel changed title from Draft: split track containers and upstream proto persistency fixes to Draft: split track containers and persistency (versioning)

    changed title from Draft: split track containers and upstream proto persistency fixes to Draft: split track containers and persistency (versioning)

  • Maarten Van Veghel changed the description

    changed the description

  • added 1 commit

    • 32b16214 - added readers for old persistency versions

    Compare with previous version

  • Sevda Esen mentioned in merge request !2358 (merged)

    mentioned in merge request !2358 (merged)

  • Sascha Stahl mentioned in issue #526

    mentioned in issue #526

  • added 1 commit

    • 72513b3f - output always latest persistency version; config cleanup

    Compare with previous version

  • Maarten Van Veghel resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Maarten Van Veghel added 147 commits

    added 147 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • changed milestone to %RTA/2023.07.04

  • Maarten Van Veghel changed the description

    changed the description

  • Maarten Van Veghel marked this merge request as ready

    marked this merge request as ready

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading