SL: SLB lines as sprucing with persitreco=False
This MR follows the discussion. Here we duplicate all SLB Hlt2 lines with persistreco=True
(essentially all of them) into sprucing lines with persitreco=False
.
To do:
-
After discussion with WG turn the persistreco=True
as true for select few lines for which the isolation studies need to be conducted. -
Add a OR for Hlt2Topo2BodyDecision || Hlt2Topo3BodyDecision || <corresponding_line_in_hlt2>
. This would be helpful for overlap studies.
FYI: @jugarcia , @sklaver , @mvesteri , @poluekt, @gciezare
Keeping track of Sprucing selections in DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/78. https://gitlab.cern.ch/lhcb-dpa/project/-/issues/243
Merge request reports
Activity
added SLB Line label
assigned to @amathad
- Resolved by Nicole Skidmore
@nskidmor : These are essentially duplicates for the Hlt2 lines. Let me know if there is some optimisation we can do here e.g. should we add filter on the respective hlt2 lines (with
hlt2_filter_code
)?Edited by Abhijit Mathad
added RTA label
mentioned in merge request !2342 (merged)
- Resolved by Eduardo Rodrigues
@amathad, @nskidmor, great to see the filters to be efficient
. This reminds me - would it make sense to add a warning to theSpruceLine
class in case no filters are given? I mean, in principle one should always run a Sprucing line on some HLT2 line (certainly for the bulk of the use-cases) at least, hence good to hint.
added hlt2 label
- Resolved by Abhijit Mathad
- Resolved by Abhijit Mathad
- Resolved by Abhijit Mathad
- Resolved by Abhijit Mathad
added 52 commits
-
5d3119d6...32f59261 - 51 commits from branch
master
- acadc73f - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Moore into AM_spruce
-
5d3119d6...32f59261 - 51 commits from branch
mentioned in merge request !2068 (merged)
added selection label
added June-2023-data label
removed June-2023-data label
added Spruce_June23 label
mentioned in merge request !2347 (merged)
added 3 commits
-
7167673b...1a791258 - 2 commits from branch
master
- a17e3184 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Moore into AM_spruce
-
7167673b...1a791258 - 2 commits from branch
added 56 commits
-
a17e3184...66fe3dd2 - 55 commits from branch
master
- af7eae2d - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Moore into AM_spruce
-
a17e3184...66fe3dd2 - 55 commits from branch
added 30 commits
- af7eae2d...131f3ad0 - 20 earlier commits
- a152dd20 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Moore into SLB_AM_KSLambda
- f9736edc - add persistreco
- 79265905 - apply Suzanne's comment
- 6e5a0e20 - Rename lines based on https://codimd.web.cern.ch/1FARROp8R1mdd5zCHLktlA?view
- 38842fc3 - undo changes to lines which will be removed by l anyway
- 439ce1a5 - undo changes to lines which will be removed by MR2347 anyway
- 3a65b069 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Moore into SLB_AM_KSLambda
- 0d997190 - name changes
- 1c03155b - Merge branch 'anmorris_SLB_naming_convention' of...
- 74ddd775 - Merge branch 'SLB_AM_KSLambda' of ssh://gitlab.cern.ch:7999/lhcb/Moore into AM_spruce
Toggle commit listadded 5 commits
Toggle commit listrequested review from @abertoli
Hi @abertoli and @nskidmor , This MR sits on top of the three Moore MRs that have been tested and due to be merged since weeks. I hope they all go in together.
PS: I will be on paternity leave for two weeks starting tomorrow. So please contact Andy or Julian or Suzane in case of emergencies.
Edited by Abhijit Mathadassigned to @yagao
@yagao : Could you please trigger a test with the above dependencies?
- Resolved by Abhijit Mathad
/ci-test !2430 (merged) !2068 (merged) !2347 (merged)
added ci-test-triggered label
- [2023-06-19 15:29] Validation started with lhcb-master-mr#8286
- [2023-06-20 10:45] Validation started with lhcb-master-mr#8300
Edited by Software for LHCbadded hlt2-throughput-decreased label