Skip to content
Snippets Groups Projects

SL: SLB lines as sprucing with persitreco=False

Merged Abhijit Mathad requested to merge AM_spruce into master

This MR follows the discussion. Here we duplicate all SLB Hlt2 lines with persistreco=True (essentially all of them) into sprucing lines with persitreco=False.

To do:

  • After discussion with WG turn the persistreco=True as true for select few lines for which the isolation studies need to be conducted.
  • Add a OR for Hlt2Topo2BodyDecision || Hlt2Topo3BodyDecision || <corresponding_line_in_hlt2>. This would be helpful for overlap studies.

FYI: @jugarcia , @sklaver , @mvesteri , @poluekt, @gciezare

Keeping track of Sprucing selections in DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/78. https://gitlab.cern.ch/lhcb-dpa/project/-/issues/243

Edited by Abhijit Mathad

Merge request reports

Merge request pipeline #6061829 failed

Merge request pipeline failed for 2cba6a37

Approved by

Merged by Nicole SkidmoreNicole Skidmore 1 year ago (Aug 25, 2023 3:25pm UTC)

Merge details

  • Changes merged into master with 7996fdf4 (commits were squashed).
  • Deleted the source branch.

Pipeline #6103271 passed

Pipeline passed for 7996fdf4 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Abhijit Mathad resolved all threads

    resolved all threads

  • Abhijit Mathad resolved all threads

    resolved all threads

  • Abhijit Mathad added 1 commit

    added 1 commit

    Compare with previous version

  • Abhijit Mathad added 52 commits

    added 52 commits

    Compare with previous version

  • Abhijit Mathad added 1 commit

    added 1 commit

    Compare with previous version

  • Abhijit Mathad mentioned in merge request !2068 (merged)

    mentioned in merge request !2068 (merged)

  • added selection label

  • Alessandro Bertolin changed the description

    changed the description

  • Abhijit Mathad mentioned in merge request !2347 (merged)

    mentioned in merge request !2347 (merged)

  • Abhijit Mathad added 3 commits

    added 3 commits

    Compare with previous version

  • Abhijit Mathad added 56 commits

    added 56 commits

    Compare with previous version

  • Abhijit Mathad added 30 commits

    added 30 commits

    Compare with previous version

  • Abhijit Mathad marked the checklist item After discussion with WG turn the persistreco=True as true for select few lines for which the isolation studies need to be conducted. as completed

    marked the checklist item After discussion with WG turn the persistreco=True as true for select few lines for which the isolation studies need to be conducted. as completed

  • Abhijit Mathad added 5 commits

    added 5 commits

    • a90034de - Unified the line builders for the B+ -> D0 tau nu modes.
    • 751dd5cb - Fixed a decay descriptor.
    • 10b17558 - Removed an obsolete input argument for a composite builder.
    • c51f35ec - Merge branch 'SLB_remove_duplicated_lines_new' of...
    • 72ba4ad6 - persistreco false

    Compare with previous version

  • Abhijit Mathad changed the description

    changed the description

  • Abhijit Mathad added 2 commits

    added 2 commits

    • d98fd851 - Remove Vub that had been missed
    • 24802d1a - Merge branch 'anmorris_SLB_naming_convention' of...

    Compare with previous version

  • Abhijit Mathad added 1 commit

    added 1 commit

    Compare with previous version

  • Abhijit Mathad added 1 commit

    added 1 commit

    Compare with previous version

  • Abhijit Mathad requested review from @abertoli

    requested review from @abertoli

  • Author Developer

    Hi @abertoli and @nskidmor , This MR sits on top of the three Moore MRs that have been tested and due to be merged since weeks. I hope they all go in together.

    PS: I will be on paternity leave for two weeks starting tomorrow. So please contact Andy or Julian or Suzane in case of emergencies.

    Edited by Abhijit Mathad
  • assigned to @yagao

  • Author Developer

    @yagao : Could you please trigger a test with the above dependencies?

  • Abhijit Mathad marked this merge request as ready

    marked this merge request as ready

  • Edited by Software for LHCb
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading