Add spruce lines for SMOG2
This MR adds sprucing lines for SMOG2 proton-nucleus collisions. The sprucing lines use the same line builders as the SMOG2 HLT2 lines and are each filtered on the output of one of the HLT2 lines. The sprucing lines added here include lines for PID calibration, dimuon lines, charm lines, and minimum bias lines.
The sprucing line rates are tested on HLT2-filtered SMOG2 MC. The lines are tested on simulated pAr collision events and on simulated events with simultaneous pp and pAr collisions ("pp+pAr"). Note that each sprucing line is filtered on the corresponding SMOG2 HLT2 line decision. The following rate tests were performed:
- Rates with the projected 2023 conditions of the VELO closed at 10mm:SMOG2_Sprucing_rates.pdf.
- Rates with the updated 2023 conditions of the VELO closed at 48mm, and rates with the 2022 conditions: SMOG2_sprucing_line_rates_with_updated_2023_conditions.pdf
These lines are the same for both simultaneous pp+pAr data-taking and pAr-standalone data-taking. They should also be run in pp collisions, although due to the PVz requirement in the lines (requiring a PV between -300mm and -700mm), the rate on pp-only collisions should be very low.
Several of the commits in this MR overlap with those in !2366 (merged). In order to meet the deadline for sprucing lines, we are proceeding with these MRs in parallel, and they each need these shared commits.
Work towards DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/78.
Merge request reports
Activity
added DPA label
added RTA label
added Spruce_June23 label
added 133 commits
-
7b7241f6...2e18e72c - 102 commits from branch
master
- 2e18e72c...f2122a00 - 21 earlier commits
- 077bbbfb - Fix typo in docs
- a7b8722b - Fix typo in Hlt2Conf.profile_config test
- 424f5fa9 - delete obsolete unit test
- 3de11f8f - Remove reference to test_pass_spruce_2022_data_100ev in CMakeLists.txt
- 312003ff - Add dimuon sprucing lines for SMOG2
- 90de23b3 - Add SMOG2 charm sprucing lines
- 7f84c453 - Add charged PID sprucing lines
- f97d6fd0 - Require sprucing lines to filter on HLT2 lines and change doca to sdoca
- bf69fc70 - Fixed formatting
- c8b79b6f - Add sprucing lines for SMOG2 lumi and MB, update cuts
Toggle commit list-
7b7241f6...2e18e72c - 102 commits from branch
added 7 commits
- 80c7ab7b - Revert "Fix sanitizer build"
- 41cb37f9 - Revert "Docs update for MooreAnalysis!122 (merged) and MooreAnalysis!118 (merged)"
- 2a490219 - Revert "allow default monitoring of filtered combiners"
- c68d2ef9 - Revert "Fix typo in docs"
- 7bc9427f - Revert "Fix typo in Hlt2Conf.profile_config test"
- 44ab4aa9 - Revert "delete obsolete unit test"
- 7478b9d2 - Revert "Remove reference to test_pass_spruce_2022_data_100ev in CMakeLists.txt"
Toggle commit listadded 2 commits
added DPA-WP1 label
- Resolved by Kara Mattioli
@kmattiol quick questions:
- does this MR contains only Spruce lines ?
- if we want to ran some /ci-test on this MR to we have to ran the code together with 2366 ? is this what you mean ?
- I admit that I have no experience about pAr but a see a few lines with a double digit retention on min bias like:
10 % retention on minbias is quite large ... for pp I can tell you that the OVERALL retention of the B2OC Spruce lines BEFORE the tuning of a few high rate lines is ... 8 %
Edited by Alessandro Bertolin
- Resolved by Kara Mattioli
concerning retentions:
- I am mostly concerned by the D02KPi line that shows a larger rate than D02pipi
- can we set a prescale for the
_Kmprobe
,_Kpprobe
andPassthrough
if needed ?
- Resolved by Alessandro Bertolin
- I changed the title to make clear that this is adding also Hlt2 lines
- let me know when we can trigger the tests on this branch, we have to test before we can merge of course
- concerning the two digits retentions you must understand that if the retentions will turn out to be too large during data processing it may be difficult to issue a fix on a short time scale and so we will prescale or turn off, it looks to me you are quite confident that the retentions will be fine so let's continue like that
- Resolved by Alessandro Bertolin
@kmattiol can you please write here if these newly added lines must be ran also in pp ? there was a statement from Saverio about that but I do not remember the answer
if some lines are for both pp pAr and some just for pAr please provide a corresponding list