Calo decoding in HLT2 BW tests

requested review from @shunan, @rmatev, and @cmarinbe

added 1 commit

• 54aca9bc - Fixed formatting

Compare with previous version

added PR/Moore_hlt2_bandwidth label

added RTA label

mentioned in merge request !2161 (merged)

• [2023-06-23 11:47] Validation started with lhcb-master-mr#8347
• [2023-06-27 09:35] Validation started with lhcb-master-mr#8381

mentioned in issue #598 (closed)

Thanks @alobosal for the fix! I made a comparison between lhcb-master-mr.8347 and lhcb-master.2060, you can find the full comparison table attatched below. I do see lots of lines containing electrons now have a non-zero rate. Good job!

Now I just wonder if this fix also needs to be applied to the Sprucing BW test? Namely in these two files:

• spruce_bandwidth_streamless.py
• spruce_bandwidth_wg_streams.py

I didn't see this Calo-related errors in the Sprucing BW tests in PR but I'm not sure they are affected or not. Could you comment @rmatev @cmarinbe ? Thanks.

compare_lhcb-master.2058_lhcb-master-mr.8347.csv

resolved all threads

thanks a lot for finding this and providing a fix @alobosal Given the calo raw bank type depends on the input file and not the options themselves, I wouldn't modify the options. Instead, I suggest passing the dedicated file https://gitlab.cern.ch/lhcb/Moore/-/blob/master/Hlt/Moore/options/calo_decoding_packed.py in the bandwidth test script https://gitlab.cern.ch/lhcb-datapkg/PRConfig/-/blob/master/scripts/benchmark-scripts/Moore_hlt2_bandwidth.sh similarly to what was done in lhcb-datapkg/PRConfig!287 (merged) for the throughput tests

mentioned in issue #599 (closed)

mentioned in merge request lhcb-datapkg/PRConfig!320 (merged)

approved this merge request

unapproved this merge request

resolved all threads

Closing upon lhcb-datapkg/PRConfig!320 (merged)

closed