Skip to content
Snippets Groups Projects

Prep for sprucing productions

Merged Prep for sprucing productions
preforSprucingprod into master
1 unresolved thread
Merged Nicole Skidmore requested to merge preforSprucingprod into master
1 unresolved thread

Merge request reports

Merge request pipeline #5998237 passed

Stage: check
    Stage: build
      Stage: docs
        Stage: .post

          Merge request pipeline passed for 32b4aa58

          Merged by Nicole SkidmoreNicole Skidmore 1 year ago (Aug 4, 2023 8:50am UTC)

          Loading

          Pipeline #6001258 passed

          Stage: check
            Stage: build
              Stage: docs
                Stage: deploy

                  Pipeline passed for 263bb2f6 on master

                  Activity

                  Filter activity
                  • Approvals
                  • Assignees & reviewers
                  • Comments (from bots)
                  • Comments (from users)
                  • Commits & branches
                  • Edits
                  • Labels
                  • Lock status
                  • Mentions
                  • Merge request status
                  • Tracking
                  Hlt/Hlt2Conf/python/Hlt2Conf/Sprucing_production.py
                  191 #missing_lines = lines_not_running(all_lines, lines_to_run)
                  156 print("Banks for each stream : ", streams_spruce.stream_banks)
                  192 157
                  193 158 def make_streams():
                  194
                  195 159 streamdict = {
                  196 wg: [PassLine(
                  197 name="Pass" + wg,
                  198 hlt2_filter_code=lineregex[wg],
                  199 )]
                  200 for wg in linedict if "rb" not in wg
                  160 wg: [
                  161 PassLine(
                  162 name="Pass" + wg,
                  163 hlt2_filter_code=turcallinedict[wg],
                  164 )
                  • Comment on lines -182 to +164
                    Ross John Hunter
                    Ross John Hunter @rjhunter ·
                    Developer

                    Hi @nskidmor, following on from our conversation this morning, I'm curious as why you moved away from generating a big list of filter codes from the HLT2 modules and moved towards a Regex-based way of streaming?

                    I was just thinking independently that (in conjunction with the ideas in !2536 (closed)) that if the HLT2 stream configuration is written compactly, could you not import that configuration in to give the hlt2 filter code in the sprucing pass through? This would eliminate the need for any regexing/special naming of the FULL stream like we discussed, and means we only define a stream configuration in 1 place - just use it here.

                    Did you do this way to be pragmatic/get something that works now? I think this case is an improvement on having to fully write the TURBO stream configuration again here in Sprucing_production.py BTW, which is what it looks like was done before this MR.

                    Edited by Ross John Hunter
                  • Please register or sign in to reply
                  Please register or sign in to reply