cleanup of Hlt1Conf algorithm.py

Remove obsolete methods and adapt the smog line to work with the existing Filter method.

unmarked as a Work In Progress

The best code is no code!

I'm testing a couple of other MRs tonight, so will review and label this for testing tomorrow.

added ~1663 hlt1 labels

assigned to @apearce

Note that this will probably conflict with !260 (merged) ..

added 1 commit

• 481dfb10 - remove deprecated methods

Compare with previous version

added 1 commit

• d404e524 - Fixed formatting

Compare with previous version

resolved all threads

Tests fail for me locally, you will need to update anything that refers to the _deprecated muon methods.

$ grep -rl _deprecated Moore
Moore/Hlt/RecoConf/options/hlt1_reco_baseline_deprecated.py
Moore/Hlt/RecoConf/python/RecoConf/standalone.py
Moore/Hlt/RecoConf/tests/qmtest/hlt1_reco_baseline_deprecated.qmt
Moore/Hlt/RecoConf/tests/refs/hlt1_reco_baseline_deprecated.ref.new
Moore/Hlt/RecoConf/tests/refs/hlt1_reco_baseline_deprecated.ref.x86_64+avx2+fma-opt
Moore/Hlt/RecoConf/tests/refs/hlt1_reco_baseline_deprecated.ref.x86_64-dbg
Moore/Hlt/RecoConf/tests/refs/hlt1_reco_baseline_deprecated.ref.x86_64-opt
Moore/Hlt/RecoConf/tests/refs/hlt1_reco_baseline_deprecated.ref.x86_64-dbg.new

You can remove the hlt1_reco_baseline_deprecated test, options file, and associated references.

added 1 commit

• bd54199d - remove deprecated tests

Compare with previous version

added 1 commit

• 8b324043 - Fixed formatting

Compare with previous version

Sorry about that. I have been schooled on how to run all tests.

added all-slots label

• [2019-10-17 17:28] Validation started with lhcb-gaudi-merge#838
• [2019-10-17 17:29] Validation started with lhcb-gaudi-merge#839
• [2019-10-17 17:29] Validation started with lhcb-gaudi-merge#841
• [2019-10-17 17:31] Validation started with lhcb-gaudi-merge#837
• [2019-10-17 17:32] Validation started with lhcb-gaudi-merge#840
• [2019-10-17 17:44] Validation started with lhcb-head#2241
• [2019-10-17 18:02] Validation started with lhcb-gaudi-merge#842
• [2019-10-17 20:41] Automatic merge failed in lhcb-tdr-test#549
• [2019-10-18 00:09] Validation started with lhcb-test-throughput2#186
• [2019-10-18 00:10] Validation started with lhcb-sanitizers#404
• [2019-10-18 00:10] Automatic merge failed in lhcb-tdr-test#707
• [2019-10-18 00:11] Validation started with lhcb-lcg-dev4#1066
• [2019-10-18 00:11] Validation started with lhcb-gaudi-head#2421
• [2019-10-18 00:11] Validation started with lhcb-lcg-dev3#1055
• [2019-10-18 00:14] Validation started with lhcb-gaudi-head-py3#203
• [2019-10-18 00:15] Validation started with lhcb-head#2402

approved this merge request

resolved all threads

removed all-slots label

merged

mentioned in commit 25f3f012

Uff, I didn't set a good message for the squashed commit so now this is all under 'fixed formatting'

Anyway, thanks a lot for the cleanup!

TIL squashing takes the most recent commit message, completely the opposite of what I expected

mentioned in issue #86 (closed)