[QEE] Spruce24: Move Hlt2_ZTrkEff to TurCal stream

#672

@cmarinbe encouraged us to move Hlt2QEE_TrackEff_ZToMuMu_{trkeff-method}_{charge}_{decision-type} lines from Full to TurCal stream like the other calibration lines (including the 'lower_mass' dimuon trkeff lines).

These lines are currently Full-stream with Sprucing lines. This MR moves them to TurCal and deletes the Sprucing lines.

Moves qee/high_mass_dimuon_tracking_efficiency to trackeff/ZTrackEfficiency.
Renames Hlt2QEE_TrackEff_ZToMuMu_{trkeff-method}_{probe-charge}_{decision-type} to Hlt2TrackEff_ZToMuMu_....
Removes all sprucing related qee changes for SpruceQEE_TrackEff_ZToMuMu.
Addresses #676 (closed) by reverting changes to several sprucing tests needed for the ZTrkEff lines.

ToDo:

• For extra safety re: the commissioning of the UT, add SeedMuon TrkEff method.
• Need to contact RTAWP4 coordinators to discuss moving to TurCal
• Remove the Sprucing lines added by !2530 (merged) and changes from !2734 (merged) (ONLY AFTER Spruce_EoY23).
• Reference updates needed for hlt2_noUT_trackefflines.qmt and hlt2_trackefflines.qmt

Closes #676 (closed)

added qee label

assigned to @lugrazet

added RTA label

added 1 commit

• 65a05743 - changed the hard-coded appearance of Hlt2QEE

Compare with previous version

Hi @lugrazet. I understand you talked to @cmarinbe and @decianm already, so I can make my comment - this is the first usecase for "future" where it would make sense to commit to 2024-patches, at which point we could go ahead with no wait for "Wait for Spruce_EoY23 before merging" and potentially other matters.

At some point we should really discuss master and 202X-patches. This triggered me again :-). OK, not a discussion for the MR, but something to have soon IMO.

[If this is related to Sprucing or has implications for it, kindly add a DPA label ;-).]

added DPA-WP1 label

added 1 commit

• adb238c6 - Fixed formatting

Compare with previous version

changed the description

mentioned in merge request !2530 (merged)

changed title from Draft: [QEE] Move Hlt2_ZTrkEff to TurCal stream to Draft: [QEE] Spruce24: Move Hlt2_ZTrkEff to TurCal stream

added 54 commits

• adb238c6...0d40eb6a - 51 commits from branch master
• 365a86a3 - Moving to TurCal
• 76f5be0f - removed 'remove Hlt2QEE_TracKEff' that no longer exist
• 72282e7d - removed now unnecesssary builder

Compare with previous version

added 2 commits

• 1057fed7 - remove now-unnecessary imports in qee_builders
• 98d81040 - Fixed formatting

Compare with previous version

changed the description

added 1 commit

• be70524e - Update hlt2_pp_thor_without_UT.py

Compare with previous version

changed the description

requested review from @rjhunter

Hi @rjhunter, is there anything you would like to say here about moving the ZTrkEff lines from QEE to TurCal/trkeff before I pass to RTA WP4 coordinators?

(This can't be merged until after Spruce_EoY23 or until after that has been officially rejected, so no urgency here, but it would be nice for everything to be in place for when it's that time)

approved this merge request

added RTA WP4 label

mentioned in merge request !2743 (merged)

changed the description

changed the description

changed the description

mentioned in merge request !2734 (merged)

changed the description

added Spruce_24 label

mentioned in issue #676 (closed)

marked the checklist item Remove the Sprucing lines added by !2530 (merged) and changes from !2734 (merged) (ONLY AFTER Spruce_EoY23). as incomplete

added 109 commits

• be70524e...002f5a8f - 107 commits from branch master
• 09fe467f - Remove changes from Moore2734 + add into trackeff qmts + rename to be more...
• 7f2d4729 - lb-format

Compare with previous version

added 1 commit

• 96bc133c - now actually using the shared kinematic cuts, will need new references

Compare with previous version

marked the checklist item For extra safety re: the commissioning of the UT, add SeedMuon TrkEff method. as completed

marked the checklist item Remove the Sprucing lines added by !2530 (merged) and changes from !2734 (merged) (ONLY AFTER Spruce_EoY23). as completed

changed the description

changed the description

added 2024data-selections label

added 153 commits

• 96bc133c...db3b3791 - 152 commits from branch master
• 659b6d0e - Merge branch 'master' into lugrazet-qee-ZTrackEff-Turcal

Compare with previous version

changed the description

added reference update label

changed the description

changed the description

Hi TurCal experts @mfontana @freiss, this MR moves the existing ZTrkEff lines from QEE (Full Stream) to TurCal for 2024. These are currently persistreco=True with no other extra_outputs. We also added an additional mode, SeedMuon, to the Z lines for some extra information while the UT is still being commissioned.

Also adds them to the existing TrkEff tests [hlt2_trackeff_test, hlt2_noUT_trackeff_test]. Locally verified the tests are finalising successfully but needs a new reference.

Is there anything further from your perspective that would be needed to facilitate this change and/or do you have any comments for us?

Edit: Rebase to resolve conflicts. Still ready to proceed.

added 15 commits

• 659b6d0e...bca9fb59 - 12 commits from branch master
• dc31e57c - Remove changes from Moore2734 + add into trackeff qmts + rename to be more...
• 42ff317f - lb-format
• 9075620e - now actually using the shared kinematic cuts, will need new references

Compare with previous version

approved this merge request

marked the checklist item Need to contact RTAWP4 coordinators to discuss moving to TurCal as completed