Draft: clean up and simplify the config
The current Moore config file became too large to handle and maintain. This is now split into main configuration for moore/allen, report writers (collecting and creating all report banks) and stream writers. Hlt1/hlt2/Spruce/pass configurations are made more explicit wherever needed.
A new Stream object (name, routing bit, lines, raw banks) is introduced to make stream configuration more clear. An additional Streams object holds the list of streams. This allows easy access to all lines in all streams when needed.
Goes with MooreAnalysis!130 (closed) lhcb-datapkg/PRConfig!357 (merged)
Superseded by !2802 (merged) due to many MR conflicts
Merge request reports
Activity
added RTA label
added 2 commits
added 2 commits
requested review from @nskidmor
/ci-test LHCb!4259 (merged)
Started integration test build. Once done, check the results or the comparison to a reference build.
Throughput Test Moore_hlt2_fastest_reco: 481.9 Events/s -- change of -0.02% vs. reference
Throughput Test Moore_hlt2_pp_thor: 233.2 Events/s -- change of 0.11% vs. reference
Throughput Test Moore_spruce_all_lines: 368.7 Events/s -- change of -1.51% vs. reference . Total bandwidth 0 GB/s -- change of -100.00% vs. reference
Throughput Test Moore_hlt1_pp_default: 26030.4 Events/s -- change of -0.02% vs. reference
added ci-test-triggered label
- [2023-11-07 18:24] Validation started with lhcb-master-mr#9630
- [2023-11-09 14:03] Validation started with lhcb-master-mr#9643
- [2023-11-10 08:28] Validation started with lhcb-master-mr#9646
- [2023-11-11 13:41] Validation started with lhcb-master-mr#9649
Edited by Software for LHCbmentioned in merge request MooreAnalysis!130 (closed)
added cleanup label
213 ) 214 ], 215 detectors=DETECTORS) for wg in turcallinedict 216 if "raw" not in wg 217 ] 218 219 streams += [ 220 Stream( 221 name=wg, 222 lines=[ 223 PassLine( 224 name="Pass" + wg, 225 hlt2_filter_code=turcallinedict[wg], 226 prescale=0.1) 227 ], 228 detectors=[]) for wg in turcallinedict if "raw" in wg changed this line in version 7 of the diff
This is a really valuable simplification of the code @sesen
added 1 commit
- cde4ce8e - fix detectors in Sprucing settings for production
mentioned in merge request Allen!1371 (closed)
- Resolved by Sevda Esen
added 1 commit
- 185c4e74 - make sure stream names are unique, add get stream function