Skip to content
Snippets Groups Projects

Draft: clean up and simplify the config

Closed Sevda Esen requested to merge sevda-clean-up-config into master

The current Moore config file became too large to handle and maintain. This is now split into main configuration for moore/allen, report writers (collecting and creating all report banks) and stream writers. Hlt1/hlt2/Spruce/pass configurations are made more explicit wherever needed.

A new Stream object (name, routing bit, lines, raw banks) is introduced to make stream configuration more clear. An additional Streams object holds the list of streams. This allows easy access to all lines in all streams when needed.

Goes with MooreAnalysis!130 (closed) lhcb-datapkg/PRConfig!357 (merged)

Superseded by !2802 (merged) due to many MR conflicts

Edited by Sevda Esen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
213 )
214 ],
215 detectors=DETECTORS) for wg in turcallinedict
216 if "raw" not in wg
217 ]
218
219 streams += [
220 Stream(
221 name=wg,
222 lines=[
223 PassLine(
224 name="Pass" + wg,
225 hlt2_filter_code=turcallinedict[wg],
226 prescale=0.1)
227 ],
228 detectors=[]) for wg in turcallinedict if "raw" in wg
  • This is a really valuable simplification of the code @sesen :smile:

  • Sevda Esen added 1 commit

    added 1 commit

    • 09c94ed7 - fix stream(s) updating, other small fixes

    Compare with previous version

  • Sevda Esen added 1 commit

    added 1 commit

    • cde4ce8e - fix detectors in Sprucing settings for production

    Compare with previous version

  • Sevda Esen mentioned in merge request Allen!1371 (closed)

    mentioned in merge request Allen!1371 (closed)

  • Sevda Esen added 1 commit

    added 1 commit

    • 185c4e74 - make sure stream names are unique, add get stream function

    Compare with previous version

  • Sevda Esen changed the description

    changed the description

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading