Skip to content
Snippets Groups Projects

BandQ: spruce lines with neutrals

Merged Yajing Wei requested to merge bandq_neutral_lines into master
  • Releasing BandQ sprucing and HLT2 lines related to neutrals and downstream tracks.
  • Moving all imports to the beginning of the file.
  • Changing line construction function from HltLine to Hlt2Line
  • Removing an unused variable

All changes made to HLT2 are moved to another MR(!2771 (merged)) to make this MR only relevant to Sprucing.

#667

Edited by Alessandro Bertolin

Merge request reports

Merge request pipeline #6576264 passed

Merge request pipeline passed for 9dd0b172

Approved by

Merged by Nicole SkidmoreNicole Skidmore 1 year ago (Dec 7, 2023 9:08am UTC)

Merge details

  • Changes merged into master with d3f9f0fa (commits were squashed).
  • Deleted the source branch.

Pipeline #6585361 passed

Pipeline passed for d3f9f0fa on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Developer

    Rate test

    Sprucing lines

    input: upgrade-minbias-hlt2-full-output-Aug2023 (rate: 100kHz)

    input events: 242k

    Line name rate (Hz)
    SpruceBandQ_BcToDs1Gamma 82 +- 6
    SpruceBandQ_BcToDs1GammaWS 31 +- 4
    SpruceBandQ_OmegabToJpsiOmega 0 +- 0
    SpruceBandQ_XibToJpsiXi 0 +- 0
    SpruceBandQ_XibToJpsiXiPi 0 +- 0

    HLT2 lines

    input: upgrade_minbias_hlt1_filtered (rate: 1MHz)

    input events: 313k

    Line name rate (Hz)
    Hlt2BandQ_BbbarToUpsilonGamma_ConvDD 3 +- 3
    Hlt2BandQ_CcbarToJpsiGamma_ConvDD 45 +- 12
    Hlt2BandQ_XToChicMuMu 0 +- 0
  • Yajing Wei added 1 commit

    added 1 commit

    • 95823740 - Udpate file structure and change to using HLT2Line function.

    Compare with previous version

  • Yajing Wei changed the description

    changed the description

  • Yajing Wei added 1 commit

    added 1 commit

    Compare with previous version

  • Yajing Wei marked this merge request as ready

    marked this merge request as ready

  • assigned to @shunan

  • assigned to @nskidmor

  • assigned to @abertoli

    • Resolved by Shunan Zhang

      Hi @yajing (cc @mengzhen ), thanks for the contribution. I don't see any outstanding problem with spruce_bandq.py but you're also adding some independent Hlt2 changes. To avoid further inconvenience in merging stuff I suggest separating your Hlt2 and Sprucing requests to 2 different MR, what do you think @abertoli @nskidmor ?

  • Yajing Wei added 1 commit

    added 1 commit

    • d643c216 - Restore changes in HLT2 lines and keep only sprucing line changes.

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading