Truth matching fix for persistreco

In Moore, truth matching was making an assumption that line output is particles implicitly. This can cause that P2MCP relations not made for all proto particle containers (4 charged, 1 neutral), especially problematic for IFT and inclusive lines relying on persistreco.

Closing #674 (closed)

added 1 commit

• df26a10f - fix truth matching for persistreco proto particles

Compare with previous version

requested review from @graven and @nskidmor

FYI @sbelin @tizhou

added RTA bug fix labels

added Persistency label

/ci-test

added ci-test-triggered label

added rta-hotfix label

removed rta-hotfix label

• [2023-12-05 18:02] Validation started with lhcb-master-mr#9810
• [2023-12-06 09:31] Validation started with lhcb-master-mr#9812
• [2023-12-07 09:36] Validation started with lhcb-master-mr#9824

added 1 commit

• 9c774e50 - fix truth matching for persistreco proto particles, allow multiple proto...

Compare with previous version

added 1 commit

• be1ccb2a - check for inputs and outputs for truth matching dependencies

Compare with previous version

/ci-test

added 1 commit

• b47e22bd - try another fix for dependency collection in case of tracks

Compare with previous version

/ci-test

assigned to @nskidmor

@bjashal can this go in soon?

@tizhou can you confirm here that the MC persistency is working for neutrals in the Sprucing with topo at HLT2 now?

Re-ping @tizhou

Hi @nskidmor and @tizhou, I was trying to follow because I faced problems with neutral truth matching as well, I assume it was fixed in your case, right? Let me mention the related issue #580 (comment 7589672), Sevda is helping me figure it out, I'm still not sure if it's a configuration problem on my side or a problem more in the roots of the matching

Thanks @alobosal, are there any updates here?

I'll try to come up with a reproducer after I manage to finish some other non related developments that I'd like to finish asap, hopefully soon

assigned to @bjashal

approved this merge request

resolved all threads

merged

mentioned in commit bade6889

mentioned in merge request !2829 (merged)

mentioned in issue #580 (closed)

mentioned in issue #738 (closed)

mentioned in merge request !3222 (merged)