Add default_VeloCluster_source

As reported in Rec#513, when using Retina Clusters for tracking, they must be used also for FullCluster decoding. This require two bind:

make_VeloClusterTrackingSIMD.bind(algorithm=VeloRetinaClusterTrackingSIMD)
make_velo_full_clusters.bind(make_full_cluster=VPRetinaFullClusterDecoder)

MC truth-matching does not provides consistent result if only one of the two bind is performed.

This MR introduces the function default_VeloCluster_source that store the bank used to produce VELO clusters: VP or VPRetinaCluster. By default make_VeloClusterTrackingSIMD and make_velo_full_clusters change the called algorithm according to the return value of the new function. Therefore, for using Retina Clusters, is sufficient to bind default_VeloCluster_source.

Functions make_VeloClusterTrackingSIMD and make_velo_full_clusters can be bound separately to use the desired algorithm.

Options files are updated to use the new function. The default source returned by default_VeloCluster_source is VP.

closes Rec#513

@ldufour @dovombru

changed the description

added RTA label

In old options files, for using RetinaClusters, some functions (e.g. get_global_measurement_provider) were bound to use make_RetinaClusters instead of make_VPClus_hits.

make_VPClus_hits already can use RetinaClusters through make_VeloClusterTrackingSIMD. Performing the bind, cluster decoding is performed two times. This is not optimal.

I removed the bind. However this removes an algorithm from the sequence and some test should be marked as failed.

mentioned in issue Rec#513

marked this merge request as ready

please first consider the impact of !2166 (merged), and only then make any remaining changes if still needed...

changed the description

added 101 commits

• afb2418f...a8f3a172 - 97 commits from branch master
• 9ceb2e96 - Added default_VeloCluster_source function that provideds the source of VeloClusters
• 8ef01d04 - Updated options files to bind default_VeloCluster_source
• 6b07253b - Fixed formatting
• ec71e2f5 - Fix standalone binds

Compare with previous version

resolved all threads

@fsouzade @roneil @lpica, the MR should be ready. Can you trigger a ci-test?

assigned to @flazzari and @msaur

added impactlow label

/ci-test

added ci-test-triggered label

• [2024-01-11 08:42] Validation started with lhcb-master-mr#10069
• [2024-01-16 11:38] Validation started with lhcb-master-mr#10132

approved this merge request

added needs ref update label

/ci-test

added 72 commits

• ec71e2f5...7f2eb982 - 67 commits from branch master
• 21479dff - Added default_VeloCluster_source function that provideds the source of VeloClusters
• d81dd114 - Updated options files to bind default_VeloCluster_source
• 54e6c7d9 - Fixed formatting
• afa5ee48 - Fix standalone binds
• d91c30e6 - Updated test_bremsstrahlung

Compare with previous version

/ci-test