Draft: SpruceLine update to support all Hlt2Line arguments

Trivial update of SpruceLine() to support all optional parameters of Hlt2Line

added DPA-WP1 Persistency labels

requested review from @sesen and @nskidmor

assigned to @msaur

added RTA label

@erodrigu @nskidmor @sesen Lately there are several comments about possibility to persist same objects for SpruceLine as for Hlt2Line plus this mattermost comment from @erodrigu:

The design has "diverged" a bit indeed, since SpruceLine inherits from Hlt2Line but then does not provide the same functionality + extras. It might be a good idea to move towards clearer mix-ins for those XXXLine classes ...

This MR adds all the missing functionalities of Hlt2Line to SpruceLine (not saying I am fully in favour of that, but that is only a personal opinion), so can be simply discussed what should be added to Sprucing and what should remain HLT2-exclusive.

Hi @msaur, I already have an MR doing this :( !3019 (merged)

We should really try to avoid duplicating effort as Im sure both of us already have too much to do. If planning to do Sprucing work maybe we can discuss beforehand?

Hello @nskidmor, sorry, I missed that MR.

This MR is just a result of some BnoC/B2CC discussion happening yesterday evening, so the plan was to just prepare a draft and then discuss it (as work itself took practically no time).

As this functionality is already implemented elsewhere I am closing this MR.

I totally understand @msaur :) There is a lot going on right now ;)

Perhaps it would be good to add check_packed_data test to sprucing as well, with all options enabled..

Yes we should make a "greedy line" that takes everything and is checked

Sounds good, we now have expected 2024 XDIGI, so even all possible MC objects could be checked that way.

requested review from @erodrigu

added 1 commit

• f7eceac6 - SpruceLine update to support all Hlt2Line arguments including monitoring

Compare with previous version

closed

resolved all threads

mentioned in merge request !3019 (merged)