Update Hlt1/Hlt2 examples for postTS
Given several changes in default Hlt2 running (Flagging mode, condensed binds, withUT) since these scripts have been created, they should be updated to reflect modern options for running Hlt2.
(There's been several versions of the same question in Upgrade Hlt2 that this should help prevent
Changes
Adds Flagging to Hlt1/Hlt2_withUT/Hlt2_withoutUT MC options. Check with expert, i.e. Sevda
Changes the error for dd4hep running on the MC builds, as per recent information : !3620 (comment 8189046)
Uses centrally defined Hlt2_withUT/Hlt2_withoutUT binds for MC and Data options.
Minor changes to the documentation to now use the withUT option at Hlt2 for MC and Data.
ToDo:
-
Update on top of !3623 (merged). - Test locally
-
dd4hep -
detdesc -
Leads to some odd results, large differences between dd4hep and detdesc : !3620 (comment 8182744)
-
-
-
Once !3623 (merged) goes in to 2024-patches, target 2024-patches
and verify the docs ci test is healthy -
Check with Sevda the usage of Hlt1/Hlt2 flagging mode make sense -
@rjhunter has agreed to review once ready -
Add qmts for these examples
Merge request reports
Activity
assigned to @lugrazet
added RTA label
- Resolved by Luke Grazette
mentioned in merge request lhcb-datapkg/PRConfig!431 (merged)
added 10 commits
-
8e57ea73...390319a5 - 6 commits from branch
2024-patches
- 624f2d30 - Now with flagging
- 18566088 - minor changes for linting
- a783c0f7 - First attempt at new Hlt2 MC scripts
- 3a610ccd - minor docstring correction
Toggle commit list-
8e57ea73...390319a5 - 6 commits from branch
added Documentation impactlow labels
- Resolved by Luke Grazette
- Resolved by Luke Grazette
requested review from @sesen
- Resolved by Luke Grazette
Hi @sesen, here I add Flagging to the Hlt1/Hlt2_withUT/Hlt2_withoutUT suggested scripts. Along the way I added a default argument to
production.py:hlt2
(lines_regex=None).As you're much more familiar with this I'm wondering if you would like to comment on the implementation? Thanks in advance
added 14 commits
- f4144dd8...4baccc61 - 4 earlier commits
- f4f48a86 - Now with flagging
- e6f34d6b - minor changes for linting
- 1ee24437 - First attempt at new Hlt2 MC scripts
- 57e868d0 - minor docstring correction
- 9683c848 - Tested, now functional
- 3e20a817 - realdata
- 35bc82cb - dd4hep options + linting
- 8f21b9ec - minor docstring edit
- b8053094 - use settings/hlt2_pp_2024(, _without_ut) to get the make_streams function and thus binds
- 7e915342 - reenable with reconstruction(from_file=False) just in case
Toggle commit listadded 2 commits
- 5709c5e8 - Refactored on-top of !3623 (merged)
- 22b85af2 - Remove frankly unnecessary production.py change to keep things cleaner
marked the checklist item Update on top of !3623 (merged). as completed
mentioned in issue lhcb-datapkg/PRConfig#26 (closed)
- Resolved by Luke Grazette
added 1 commit
- e58e2984 - now that we can use options.lines_maker, can skip using _hlt2
added 16 commits
-
e58e2984...cb376c55 - 11 commits from branch
sevda-hlt2-flagging
- 3fdd60c8 - Refactored on-top of !3623 (merged)
- 724e1607 - Remove frankly unnecessary production.py change to keep things cleaner
- d529feee - minor var rename for clarity
- ea1c5a16 - now that we can use options.lines_maker, can skip using _hlt2
- 3361c0d1 - Add new dd4hep warning information for clarity
Toggle commit list-
e58e2984...cb376c55 - 11 commits from branch
marked the checklist item Leads to some odd results, large differences between dd4hep and detdesc : !3620 (comment 8182744) as completed
added WIP dependency label
added 1 commit
- bd9f6dec - Add new dd4hep warning information for clarity
added 11 commits
-
bd9f6dec...31b7c341 - 6 commits from branch
2024-patches
- bd93cb34 - Refactored on-top of !3623 (merged)
- e9ee8cf1 - Remove frankly unnecessary production.py change to keep things cleaner
- 00ee72c1 - minor var rename for clarity
- 12c9b60b - now that we can use options.lines_maker, can skip using _hlt2
- 876bad41 - Add new dd4hep warning information for clarity
Toggle commit list-
bd9f6dec...31b7c341 - 6 commits from branch