Skip to content
Snippets Groups Projects

Update Hlt1/Hlt2 examples for postTS

Merged Luke Grazette requested to merge lugrazet-update-hlt1example into 2024-patches

Given several changes in default Hlt2 running (Flagging mode, condensed binds, withUT) since these scripts have been created, they should be updated to reflect modern options for running Hlt2. (There's been several versions of the same question in Upgrade Hlt2 that this should help prevent :smile:).

Changes

Adds Flagging to Hlt1/Hlt2_withUT/Hlt2_withoutUT MC options. Check with expert, i.e. Sevda
Changes the error for dd4hep running on the MC builds, as per recent information : !3620 (comment 8189046) Uses centrally defined Hlt2_withUT/Hlt2_withoutUT binds for MC and Data options.
Minor changes to the documentation to now use the withUT option at Hlt2 for MC and Data.

ToDo:

  • Update on top of !3623 (merged).
  • Test locally
  • Once !3623 (merged) goes in to 2024-patches, target 2024-patches and verify the docs ci test is healthy
  • Check with Sevda the usage of Hlt1/Hlt2 flagging mode make sense
  • @rjhunter has agreed to review once ready :slight_smile:
  • Add qmts for these examples
Edited by Luke Grazette

Merge request reports

Merge request pipeline #7768145 passed with warnings

Merge request pipeline passed with warnings for 6f08257f

Approved by

Merged by Christopher Rob JonesChristopher Rob Jones 8 months ago (Jul 19, 2024 10:17am UTC)

Merge details

  • Changes merged into 2024-patches with 62550d4d (commits were squashed).
  • Deleted the source branch.

Pipeline #7783853 passed

Pipeline passed for 62550d4d on 2024-patches

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Luke Grazette resolved all threads

    resolved all threads

  • Luke Grazette added 1 commit

    added 1 commit

    Compare with previous version

  • Luke Grazette changed the description

    changed the description

  • Luke Grazette added 10 commits

    added 10 commits

    Compare with previous version

  • Luke Grazette changed the description

    changed the description

  • Luke Grazette marked this merge request as ready

    marked this merge request as ready

  • Luke Grazette added 1 commit

    added 1 commit

    Compare with previous version

  • Luke Grazette added 1 commit

    added 1 commit

    Compare with previous version

  • Luke Grazette added 1 commit

    added 1 commit

    Compare with previous version

  • Luke Grazette requested review from @sesen

    requested review from @sesen

  • Luke Grazette changed the description

    changed the description

    • Author Developer
      Resolved by Luke Grazette

      Hi @sesen, here I add Flagging to the Hlt1/Hlt2_withUT/Hlt2_withoutUT suggested scripts. Along the way I added a default argument to production.py:hlt2 (lines_regex=None).

      As you're much more familiar with this I'm wondering if you would like to comment on the implementation? Thanks in advance :slight_smile:

  • Luke Grazette marked this merge request as draft

    marked this merge request as draft

  • Luke Grazette changed the description

    changed the description

  • Luke Grazette added 14 commits

    added 14 commits

    Compare with previous version

  • Luke Grazette added 2 commits

    added 2 commits

    Compare with previous version

  • Luke Grazette marked the checklist item Update on top of !3623 (merged). as completed

    marked the checklist item Update on top of !3623 (merged). as completed

  • Luke Grazette changed the description

    changed the description

  • Luke Grazette changed the description

    changed the description

  • Luke Grazette added 1 commit

    added 1 commit

    • 6fefefa2 - minor var rename for clarity

    Compare with previous version

  • Luke Grazette marked the checklist item detdesc (still building...) as completed

    marked the checklist item detdesc (still building...) as completed

  • Sevda Esen changed target branch from 2024-patches to sevda-hlt2-flagging

    changed target branch from 2024-patches to sevda-hlt2-flagging

  • Luke Grazette added 1 commit

    added 1 commit

    • e58e2984 - now that we can use options.lines_maker, can skip using _hlt2

    Compare with previous version

  • Luke Grazette changed the description

    changed the description

  • Luke Grazette added 16 commits

    added 16 commits

    • e58e2984...cb376c55 - 11 commits from branch sevda-hlt2-flagging
    • 3fdd60c8 - Refactored on-top of !3623 (merged)
    • 724e1607 - Remove frankly unnecessary production.py change to keep things cleaner
    • d529feee - minor var rename for clarity
    • ea1c5a16 - now that we can use options.lines_maker, can skip using _hlt2
    • 3361c0d1 - Add new dd4hep warning information for clarity

    Compare with previous version

  • Luke Grazette marked the checklist item Leads to some odd results, large differences between dd4hep and detdesc : !3620 (comment 8182744) as completed

    marked the checklist item Leads to some odd results, large differences between dd4hep and detdesc : !3620 (comment 8182744) as completed

  • Luke Grazette changed the description

    changed the description

  • Luke Grazette changed the description

    changed the description

  • Luke Grazette marked this merge request as ready

    marked this merge request as ready

  • Luke Grazette added 1 commit

    added 1 commit

    • bd9f6dec - Add new dd4hep warning information for clarity

    Compare with previous version

  • Sevda Esen deleted the sevda-hlt2-flagging branch. This merge request now targets the 2024-patches branch

    deleted the sevda-hlt2-flagging branch. This merge request now targets the 2024-patches branch

  • Luke Grazette added 11 commits

    added 11 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading