Charm changes for Sept 2024 deadline
Overall impact on the bandwidth
Computed from this test that was triggered here on commit 5282ce0e6082c47a15332269e6f602588578c15c.
Goals
MR collecting all modifications to HLT2 lines to be put in production in September 2024. The internal deadline is set to the 23rd of August.
Contributing
If you want to contribute to this MR, please open a new MR and target the charm-sept-2024
branch and explain your goals. Any contributions to this MR should be ready by the 23rd of August.
All the additions need to be tested locally, including:
- Impact on the bandwidth and rate: moderate rates and bandwidths should be below 100 Hz and 10 MB/s, respectively. This must be tested using
expected_2024_min_bias_hlt1_filtered_v2
. - (optional) Impact on the throughput: comparing the time with the execution of
2024-patches
with no extra modifications. - (optional) Determine efficiencies: if there is simulation already available, it will be interesting to know the efficiencies so we ensure that there is no bug in the selections.
Do not rebase or force-push to this branch without the consent of the liaison @lpica @aanelli and @cacochat, since this might lead to losses on the changes
Handling Git conflicts
Since the charm-sept-2024
branch is based on 2024-patches
, and due to the continuous development state of the latter, we frequently rebase to keep it up-to-date. If you are collaborating to an independent branch e.g. $username/charm_etc
you will need to have as a base charm-sept-2024
. You can do so via
git checkout charm-sept-2024
git checkout -b $username/charm_etc
Note that if you have been initially basing the branch on 2024-patches
at the point of changing the target branch in your merge request you will have a lot of commits from 2024-patches
that will be added to charm-sept-2024
, which will add noise to the set of changes and be a source of potential conflicts. Something similar might happen if we rebase charm-sept-2024
. In both cases, we recommend to backup your branch with a new name (just in case) and then make use of the --onto
argument of git rebase
.
Changes
Please follow the same format as in !3608 (merged).
hyperons @mstahl !3743 (merged)
-
Use OWNPVIPCHI2
instead ofMINIPCHI2(pvs)
for basic particles as described in !2886
cbaryon_to_ph0_btag @hagao !3249 (merged)
-
Use ParticleAdder
instead ofParticleVertexFitter
forHlt2Charm_Lb0ToLcpPim_LcpToPPi0
lines -
Tighten PT cuts for resolved pi0