Skip to content

bug fix: Make sure the hash remains at the end of the instance name

Gerhard Raven requested to merge fix-standard-paricles-suffix into 2024-patches

In some cases, algorithm names either had 2 hashes included, eg. make_..._{hash}_rs_{hash}, or were of the form make_..._{hash}_rs. In these cases, the code which analyses counter mismatches to see whether they are simply due to the name of the algorithm changing solely because of a change in the hash did not recognize these cases, resulting in a false positive message of counter mismatches such as:

Missing algos with Counters : std_make_detached_mumu_8954524a_rs
  Counters for algo std_make_detached_mumu_8954524a_rs
    (std_make_detached_mumu_8954524a_rs ref) # passed | 10 | 7 | ( 70.00000 +- 14.49138)%
    (std_make_detached_mumu_8954524a_rs ref) # passed CombinationCut | 18 | 12 | ( 66.66667 +- 11.11111)%
    (std_make_detached_mumu_8954524a_rs ref) # passed CompositeCut | 12 | 9 | ( 75.00000 +- 12.50000)%
    (std_make_detached_mumu_8954524a_rs ref) # passed vertex fit | 12 | 12 | ( 100.0000 +- 0.000000)%
    (std_make_detached_mumu_8954524a_rs ref) Input1 size | 10 | 23 | 2.3000
    (std_make_detached_mumu_8954524a_rs ref) Input2 size | 10 | 23 | 2.3000
    (std_make_detached_mumu_8954524a_rs ref) candidate multiplicity | 10 | 9 | 0.90000 | 0.70000 | 0.0000 | 2.0000

Extra algos with Counters : std_make_detached_mumu_7a7b382a_rs
  Counters for algo std_make_detached_mumu_7a7b382a_rs
    (std_make_detached_mumu_7a7b382a_rs new) # passed | 10 | 7 | ( 70.00000 +- 14.49138)%
    (std_make_detached_mumu_7a7b382a_rs new) # passed CombinationCut | 18 | 12 | ( 66.66667 +- 11.11111)%
    (std_make_detached_mumu_7a7b382a_rs new) # passed CompositeCut | 12 | 9 | ( 75.00000 +- 12.50000)%
    (std_make_detached_mumu_7a7b382a_rs new) # passed vertex fit | 12 | 12 | ( 100.0000 +- 0.000000)%
    (std_make_detached_mumu_7a7b382a_rs new) Input1 size | 10 | 23 | 2.3000
    (std_make_detached_mumu_7a7b382a_rs new) Input2 size | 10 | 23 | 2.3000
    (std_make_detached_mumu_7a7b382a_rs new) candidate multiplicity | 10 | 9 | 0.90000 | 0.70000 | 0.0000 | 2.0000

This MR insures that the _{hash} suffix remains at the end of the instance name, and as a side-effect, also eliminates the few cases where the hash was present twice in the name.

Edited by Gerhard Raven

Merge request reports