Adding the stream as an argument to the Turbo Lines

changed milestone to %RTA 2025 Data taking

added qee label

requested review from @isanders and @ahabdelm

added 1 commit

0983e0d5 - pre-commit fixes

Hey @paandreo, thanks for the work, although only the new Turbo lines (new since last year) need this! If you add it to all the Turbo lines we'll have to cross-reference that the stream definition you give here is the same as last year in the case of all lines that were there last year (i.e. most). Probs simplest to just add for the lines added this year.

Shunan and I did say this, but apologies if it wasn't clear.

Many apologies Ross! I will change just the new ones, but I have one question, then: what about lines that were there last year but got updated? Do I need to include the stream for them, too?

We will only need to provide the stream if it's a new line, or the line name was updated. By default the stream will be inferred from a JSON file of the stream definition from last year, so that will fail if both a) cannot find the name in that JSON file and b) stream attribute isn't provided.

there should now be a qmtest that checks this (maybe following Shunan's links will help) that you could run locally to check that you caught all the cases.

Hi @rjhunter a brief update on this. Yesterday, I discussed offline with Shunan and it seems that there is no qmt test to check automatically if one has catched all the changes in the lines wrt to the last stream division. He said that adding the stream argument for existing lines in 2024 will cause the stream set by the new configuration to override the old one.

I am now trying to check manually the differences between the stream arguments I set in this MR and the ones got from Nicole's last turbo streaming config but I have to fix some problems in my local stack

Hi @paandreo, thanks for the update.

I just asked on !4591 (merged) what the situation is, because I'm getting mixed messages.

What's the status of this MR now? Are you still checking that your assignments match up with last year's config that you linked to?

At the moment I have one JSON qee_streamsplit_comparison.json collecting all the turbo lines, split in same_stream, different_streams, only_in_old, only_in_new. Izaac tested this branch as it is now offline and it works.

I was waiting to change the stream argument for all the not only_in_new lines because I was not able to guess what is the best strategy and the discussion in that thread was still ongoing by yesterday afternoon

Sorry I don't quite understand, are you saying that you are unsure what streams to use for the lines in only_in_new?

Apologies. I was saying that I was not sure if it is fine to update the old lines with the newer stream given that it seems it won't cause any problem. If you think it is best to avoid any overwriting, I will just leave the lines in only_in_new

For a small MR diff and to be safe, I think you should leave lines that were defined last year unchanged, and only add the stream attribute to lines that are new / have a new name for this year.