Skip to content
Snippets Groups Projects

add UP tracking system

Open add UP tracking system
run5_UP_mingjie into run5
2 unresolved threads
Open Mingjie Feng requested to merge run5_UP_mingjie into run5
2 unresolved threads

rebase !4622 (closed) to the latest run5 branch

It should be merged with Rec!4288 (merged)

  1. UPStandalone
  2. TV-MT matching with UP track
  3. Downstream
  4. Upstream

Merge request reports

Merge request pipeline #11620757 failed

Stage: check
Stage: build
Stage: docs
Stage: .post

Merge request pipeline failed for fcb20340

Ready to merge by members who can write to the target branch.
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Hlt/RecoConf/python/RecoConf/upgrade2_reconstruction.py
447 return PrChecker_MatchUP(
448 Tracks=tracks,
449 MCPropertyInput=make_track_info(),
450 tvLinks=velo_tracks["ClusterLinks"],
451 upLinks=up_tracks["ClusterLinks"],
452 ftLinks=scifi_tracks["ClusterLinks"],
453 MCParticles=get_mc_particles(),
454 trackType=Ttype,
455 isFT=is_ft,
456 isFilter=is_filter,
457 isLongWithUP=is_LongWithUP)
458
459
383 460 @configurable
384 461 def pv_efficiency(vertices,
385 462 tracks,
  • Renato Quagliani approved this merge request

    approved this merge request

  • Renato Quagliani
    Renato Quagliani @rquaglia ·
    Developer

    @mingjie , i have tested running on this branch, I think all seems to be correct, however on our default options list to run algorithms i never see the StandaloneUP checker enabled. Do you have an example script where this is done? To have this merged i think :

    • We must add a PrChecker to any PR algorithms executed in the sequence and at the moment the StandaloneUP has not its own checker.

    • The StandaloneUP should have its own execution in standalone.py option as well and the appropriate Checker as well

    Feel free to share an option file where you tried this and we can create some configuration to run that.

    Edited by Renato Quagliani
    • M
      Mingjie Feng @mingjie ·
      Author Developer

      Hi @Renato, for the first question, I am not sure if I understand your question clearly.

      For the standaloneUP track, I use PrChecker directly and add some options like

      "17_UT_P>5GeV": "isUT & over5", to category Upstream (mc_checking_categories.py)

      And in fact, I have a question about this part. Should we consider adding a new category, such as UP, to mc_checking_categories.py, or would it be better to include additional options within the existing Upstream category?

      For the second question, no problem! I will add the option as soon as possible

      Edited by Mingjie Feng
  • Renato Quagliani
    Renato Quagliani @rquaglia ·
    Developer

    Hi @mingjie For the first question I meant that if we do run a StandaloneUP tracking with UP hits only we need to add its checker and its interesting categories, we can work them out but I would say we need :

    hasUP

    hasVelo &hasUP

    hasVelo & hasUP & has MT (of ft/mp split)

    hasUP & hasMT

    hasUP &hasMT & !hasVelo

    I would create a new category indeed called somewhat StandaloneUP category

    What i meant is that being this a standalone algorithm it can be added also in the standalone.py sequence.

    Edited by Renato Quagliani
    • Please register or sign in to reply